From: Qi Zheng <zhengqi.arch@bytedance.com>
To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru,
vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org,
brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu,
steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org,
yujie.liu@intel.com, gregkh@linuxfoundation.org,
muchun.song@linux.dev
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
kvm@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-erofs@lists.ozlabs.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org,
rcu@vger.kernel.org, netdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
dm-devel@redhat.com, linux-raid@vger.kernel.org,
linux-bcache@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org,
Qi Zheng <zhengqi.arch@bytedance.com>,
Carlos Llamas <cmllamas@google.com>
Subject: [PATCH v3 01/49] binder: fix memory leak in binder_init()
Date: Thu, 27 Jul 2023 16:04:14 +0800 [thread overview]
Message-ID: <20230727080502.77895-2-zhengqi.arch@bytedance.com> (raw)
In-Reply-To: <20230727080502.77895-1-zhengqi.arch@bytedance.com>
In binder_init(), the destruction of binder_alloc_shrinker_init() is not
performed in the wrong path, which will cause memory leaks. So this commit
introduces binder_alloc_shrinker_exit() and calls it in the wrong path to
fix that.
Fixes: f2517eb76f1f ("android: binder: Add global lru shrinker to binder")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder.c | 1 +
drivers/android/binder_alloc.c | 6 ++++++
drivers/android/binder_alloc.h | 1 +
3 files changed, 8 insertions(+)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 486c8271cab7..d720f93d8b19 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -6617,6 +6617,7 @@ static int __init binder_init(void)
err_alloc_device_names_failed:
debugfs_remove_recursive(binder_debugfs_dir_entry_root);
+ binder_alloc_shrinker_exit();
return ret;
}
diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index 662a2a2e2e84..e3db8297095a 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -1087,6 +1087,12 @@ int binder_alloc_shrinker_init(void)
return ret;
}
+void binder_alloc_shrinker_exit(void)
+{
+ unregister_shrinker(&binder_shrinker);
+ list_lru_destroy(&binder_alloc_lru);
+}
+
/**
* check_buffer() - verify that buffer/offset is safe to access
* @alloc: binder_alloc for this proc
diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
index 138d1d5af9ce..dc1e2b01dd64 100644
--- a/drivers/android/binder_alloc.h
+++ b/drivers/android/binder_alloc.h
@@ -129,6 +129,7 @@ extern struct binder_buffer *binder_alloc_new_buf(struct binder_alloc *alloc,
int pid);
extern void binder_alloc_init(struct binder_alloc *alloc);
extern int binder_alloc_shrinker_init(void);
+extern void binder_alloc_shrinker_exit(void);
extern void binder_alloc_vma_close(struct binder_alloc *alloc);
extern struct binder_buffer *
binder_alloc_prepare_to_free(struct binder_alloc *alloc,
--
2.30.2
next prev parent reply other threads:[~2023-07-27 8:10 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:04 [PATCH v3 00/49] use refcount+RCU method to implement lockless slab shrink Qi Zheng
2023-07-27 8:04 ` Qi Zheng [this message]
2023-07-27 8:04 ` [PATCH v3 02/49] mm: move some shrinker-related function declarations to mm/internal.h Qi Zheng
2023-07-27 8:04 ` [PATCH v3 03/49] mm: vmscan: move shrinker-related code into a separate file Qi Zheng
2023-07-27 8:04 ` [PATCH v3 04/49] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations Qi Zheng
2023-07-28 8:13 ` Simon Horman
2023-07-28 8:19 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 05/49] mm: shrinker: add infrastructure for dynamically allocating shrinker Qi Zheng
2023-07-28 12:17 ` Simon Horman
2023-07-29 8:47 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 06/49] kvm: mmu: dynamically allocate the x86-mmu shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 07/49] binder: dynamically allocate the android-binder shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 08/49] drm/ttm: dynamically allocate the drm-ttm_pool shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 09/49] xenbus/backend: dynamically allocate the xen-backend shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 10/49] erofs: dynamically allocate the erofs-shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 11/49] f2fs: dynamically allocate the f2fs-shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 12/49] gfs2: dynamically allocate the gfs2-glock shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 13/49] gfs2: dynamically allocate the gfs2-qd shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 14/49] NFSv4.2: dynamically allocate the nfs-xattr shrinkers Qi Zheng
2023-07-27 8:04 ` [PATCH v3 15/49] nfs: dynamically allocate the nfs-acl shrinker Qi Zheng
2023-07-27 9:06 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 16/49] nfsd: dynamically allocate the nfsd-filecache shrinker Qi Zheng
2023-07-27 9:08 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 17/49] quota: dynamically allocate the dquota-cache shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 18/49] ubifs: dynamically allocate the ubifs-slab shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 19/49] rcu: dynamically allocate the rcu-lazy shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 20/49] rcu: dynamically allocate the rcu-kfree shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 21/49] mm: thp: dynamically allocate the thp-related shrinkers Qi Zheng
2023-07-27 8:04 ` [PATCH v3 22/49] sunrpc: dynamically allocate the sunrpc_cred shrinker Qi Zheng
2023-07-27 9:10 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 23/49] mm: workingset: dynamically allocate the mm-shadow shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 24/49] drm/i915: dynamically allocate the i915_gem_mm shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 25/49] drm/msm: dynamically allocate the drm-msm_gem shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 26/49] drm/panfrost: dynamically allocate the drm-panfrost shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 27/49] dm: dynamically allocate the dm-bufio shrinker Qi Zheng
2023-07-27 9:13 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker Qi Zheng
2023-07-27 8:30 ` Damien Le Moal
2023-07-27 8:55 ` Qi Zheng
2023-07-27 10:20 ` Damien Le Moal
2023-07-27 10:32 ` Qi Zheng
2023-07-27 22:59 ` Dave Chinner
2023-07-27 23:48 ` Damien Le Moal
2023-07-27 8:04 ` [PATCH v3 29/49] md/raid5: dynamically allocate the md-raid5 shrinker Qi Zheng
2023-07-27 9:15 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 30/49] bcache: dynamically allocate the md-bcache shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 31/49] vmw_balloon: dynamically allocate the vmw-balloon shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 32/49] virtio_balloon: dynamically allocate the virtio-balloon shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 33/49] mbcache: dynamically allocate the mbcache shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 34/49] ext4: dynamically allocate the ext4-es shrinker Qi Zheng
2023-07-27 9:17 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 35/49] jbd2,ext4: dynamically allocate the jbd2-journal shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 36/49] nfsd: dynamically allocate the nfsd-client shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 37/49] nfsd: dynamically allocate the nfsd-reply shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 38/49] xfs: dynamically allocate the xfs-buf shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 39/49] xfs: dynamically allocate the xfs-inodegc shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 40/49] xfs: dynamically allocate the xfs-qm shrinker Qi Zheng
2023-07-27 9:19 ` Qi Zheng
2023-07-27 8:04 ` [PATCH v3 41/49] zsmalloc: dynamically allocate the mm-zspool shrinker Qi Zheng
2023-07-27 8:04 ` [PATCH v3 42/49] fs: super: dynamically allocate the s_shrink Qi Zheng
2023-07-27 8:04 ` [PATCH v3 43/49] mm: shrinker: remove old APIs Qi Zheng
2023-07-27 8:04 ` [PATCH v3 44/49] drm/ttm: introduce pool_shrink_rwsem Qi Zheng
2023-07-27 8:04 ` [PATCH v3 45/49] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} Qi Zheng
2023-07-27 8:04 ` [PATCH v3 46/49] mm: shrinker: make global slab shrink lockless Qi Zheng
2023-07-27 8:05 ` [PATCH v3 47/49] mm: shrinker: make memcg " Qi Zheng
2023-07-27 8:05 ` [PATCH v3 48/49] mm: shrinker: hold write lock to reparent shrinker nr_deferred Qi Zheng
2023-07-27 8:05 ` [PATCH v3 49/49] mm: shrinker: convert shrinker_rwsem to mutex Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727080502.77895-2-zhengqi.arch@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=cmllamas@google.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=senozhatsky@chromium.org \
--cc=steven.price@arm.com \
--cc=tkhai@ya.ru \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).