From: Paul Moore <paul@paul-moore.com>
To: Phil Sutter <phil@nwl.cc>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Richard Guy Briggs <rgb@redhat.com>,
audit@vger.kernel.org, linux-audit@redhat.com,
netfilter-devel@vger.kernel.org
Subject: Re: [nf PATCH 2/2] netfilter: nf_tables: Audit log rule reset
Date: Wed, 30 Aug 2023 22:27:01 -0400 [thread overview]
Message-ID: <CAHC9VhTMMp6Xsc2phTqx9T4h9VQ-ZK4mfa_+RTmOBN-8CBgnng@mail.gmail.com> (raw)
In-Reply-To: <20230829175158.20202-2-phil@nwl.cc>
On Tue, Aug 29, 2023 at 2:24 PM Phil Sutter <phil@nwl.cc> wrote:
>
> Resetting rules' stateful data happens outside of the transaction logic,
> so 'get' and 'dump' handlers have to emit audit log entries themselves.
>
> Cc: Richard Guy Briggs <rgb@redhat.com>
> Fixes: 8daa8fde3fc3f ("netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> include/linux/audit.h | 1 +
> kernel/auditsc.c | 1 +
> net/netfilter/nf_tables_api.c | 18 ++++++++++++++++++
> 3 files changed, 20 insertions(+)
See my comments in patch 1/2.
Acked-by: Paul Moore <paul@paul-moore.com>
--
paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2023-08-31 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 17:51 [nf PATCH 1/2] netfilter: nf_tables: Audit log setelem reset Phil Sutter
2023-08-29 17:51 ` [nf PATCH 2/2] netfilter: nf_tables: Audit log rule reset Phil Sutter
2023-08-29 18:02 ` Pablo Neira Ayuso
2023-08-30 15:47 ` Pablo Neira Ayuso
2023-08-31 2:27 ` Paul Moore [this message]
2023-08-29 18:02 ` [nf PATCH 1/2] netfilter: nf_tables: Audit log setelem reset Pablo Neira Ayuso
2023-08-29 18:38 ` Phil Sutter
2023-08-30 15:46 ` Pablo Neira Ayuso
2023-08-30 20:54 ` Richard Guy Briggs
2023-08-31 2:26 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTMMp6Xsc2phTqx9T4h9VQ-ZK4mfa_+RTmOBN-8CBgnng@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).