From: Paul Moore <paul@paul-moore.com>
To: linux-audit@redhat.com, Jeff Mahoney <jeffm@suse.com>
Subject: Re: [PATCH] audit: don't deref the syscall args when checking the openat2 open_how::flags
Date: Wed, 9 Feb 2022 18:45:41 -0500 [thread overview]
Message-ID: <CAHC9VhSnySs1kGvxb36yBUv0P++wCOX00y6XrpQ6gtA+YpQXsg@mail.gmail.com> (raw)
In-Reply-To: <164444111699.153511.15656610495968926251.stgit@olly>
On Wed, Feb 9, 2022 at 4:11 PM Paul Moore <paul@paul-moore.com> wrote:
>
> As reported by Jeff, dereferencing the openat2 syscall argument in
> audit_match_perm() to obtain the open_how::flags can result in an
> oops/page-fault. This patch fixes this by using the open_how struct
> that we store in the audit_context with audit_openat2_how().
>
> Cc: stable@vger.kernel.org
> Fixes: 1c30e3af8a79 ("audit: add support for the openat2 syscall")
> Reported-by: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
> ---
> kernel/auditsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged to audit/stable-5.17 with a note that Richard posted a similar
patch. Assuming this passes the automated testing (it should, manual
testing was fine), this will be sent up to Linus soon.
--
paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2022-02-09 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 21:11 [PATCH] audit: don't deref the syscall args when checking the openat2 open_how::flags Paul Moore
2022-02-09 23:45 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhSnySs1kGvxb36yBUv0P++wCOX00y6XrpQ6gtA+YpQXsg@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=jeffm@suse.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).