From: Paul Moore <paul@paul-moore.com>
To: cuigaosheng <cuigaosheng1@huawei.com>
Cc: arnd@arndb.de, paulmck@kernel.org, eparis@redhat.com,
dhowells@redhat.com, linux-audit@redhat.com,
mtk.manpages@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH] audit: fix undefined behavior in bit shift for AUDIT_BIT
Date: Sat, 5 Nov 2022 00:25:41 -0400 [thread overview]
Message-ID: <CAHC9VhRcuHHRMshLekU0aP=pwvxKpbxKwgjxoh8kZUKPAB-TPg@mail.gmail.com> (raw)
In-Reply-To: <5e5ce295-5ef1-0248-8265-886d2d0067f7@huawei.com>
On Mon, Oct 31, 2022 at 7:50 AM cuigaosheng <cuigaosheng1@huawei.com> wrote:
> > Thanks, this patch looks good, although the 'Fixes:' line above isn't
> > correct. The commit you reference may be the commit which created
> > AUDIT_BIT in include/uapi/linux/audit.h, but before that it was
> > defined in include/linux/audit.h with the original implementation
> > shipping in v2.6.6-rc1. As the original AUDIT_BIT implementation
> > predates git itself, I would suggest removing the 'Fixes' line
> > entirely and I'll simply add the usual stable marking when I merge it
> > into audit/stable-6.1. If that is okay with you I'll go ahead and
> > merge this patch which that tweak - is that okay?
>
> Yes, you are right, thanks for taking time to review this patch!
You're welcome, thanks for the fix :)
I just merged this into audit/stable-6.1 and I'll send this up to
Linus next week.
--
paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2022-11-05 4:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 2:10 [PATCH] audit: fix undefined behavior in bit shift for AUDIT_BIT Gaosheng Cui
2022-10-31 11:34 ` Paul Moore
2022-10-31 11:49 ` cuigaosheng
2022-11-05 4:25 ` Paul Moore [this message]
2022-10-31 12:19 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhRcuHHRMshLekU0aP=pwvxKpbxKwgjxoh8kZUKPAB-TPg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=arnd@arndb.de \
--cc=cuigaosheng1@huawei.com \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).