From: Gaosheng Cui <cuigaosheng1@huawei.com>
To: <paul@paul-moore.com>, <eparis@redhat.com>, <mszeredi@redhat.com>,
<jack@suse.cz>, <amir73il@gmail.com>, <cuigaosheng1@huawei.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH next] audit: fix potential double free on error path from fsnotify_add_inode_mark
Date: Mon, 22 Aug 2022 10:29:05 +0800 [thread overview]
Message-ID: <20220822022905.1949007-1-cuigaosheng1@huawei.com> (raw)
Audit_alloc_mark() assign pathname to audit_mark->path, on error path
from fsnotify_add_inode_mark(), fsnotify_put_mark will free memory
of audit_mark->path, but the caller of audit_alloc_mark will free
the pathname again, so there will be double free problem.
Fix this by resetting audit_mark->path to NULL pointer on error path
from fsnotify_add_inode_mark().
Fixes: 7b1293234084d ("fsnotify: Add group pointer in fsnotify_init_mark()")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
kernel/audit_fsnotify.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index 6432a37ac1c9..c565fbf66ac8 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -102,6 +102,7 @@ struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, char *pa
ret = fsnotify_add_inode_mark(&audit_mark->mark, inode, 0);
if (ret < 0) {
+ audit_mark->path = NULL;
fsnotify_put_mark(&audit_mark->mark);
audit_mark = ERR_PTR(ret);
}
--
2.25.1
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next reply other threads:[~2022-08-22 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 2:29 Gaosheng Cui [this message]
2022-08-22 8:50 ` [PATCH next] audit: fix potential double free on error path from fsnotify_add_inode_mark Jan Kara
2022-08-22 14:34 ` Paul Moore
2022-08-22 15:20 ` Jan Kara
2022-08-22 17:39 ` Paul Moore
2022-08-22 17:59 ` Jan Kara
2022-08-22 22:49 ` Paul Moore
2022-08-23 2:06 ` cuigaosheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822022905.1949007-1-cuigaosheng1@huawei.com \
--to=cuigaosheng1@huawei.com \
--cc=amir73il@gmail.com \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).