From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<mathieu.poirier@linaro.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH v9 1/3] soc: qcom: Add qcom_rproc_minidump module
Date: Fri, 3 May 2024 13:57:29 +0530 [thread overview]
Message-ID: <d8b7717c-1448-7f79-ea05-3dc9cc9bb90e@quicinc.com> (raw)
In-Reply-To: <ZjD0Yr72qv0ul3jK@hu-bjorande-lv.qualcomm.com>
On 4/30/2024 7:08 PM, Bjorn Andersson wrote:
> On Tue, Mar 26, 2024 at 07:43:12PM +0530, Mukesh Ojha wrote:
>> Add qcom_rproc_minidump module in a preparation to remove
>> minidump specific code from driver/remoteproc/qcom_common.c
>> and provide needed exported API, this as well helps to
>> abstract minidump specific data layout from qualcomm's
>> remoteproc driver.
>>
>> It is just a copying of qcom_minidump() functionality from
>> driver/remoteproc/qcom_common.c into a separate file under
>> qcom_rproc_minidump().
>>
>
> I'd prefer to see this enter the git history as one patch, extracting
> this logic from the remoteproc into its own driver - rather than as
> presented here give a sense that it's a new thing added. (I'll take care
> of the maintainer sync...)
>
> I also would prefer for this to include a problem description,
> documenting why this is done.
>
>
> I've not compared patch 1 and 3, but I'd also like a statement in the
> commit message telling if there are any changes, or if the functions are
> cleanly moved from one place to another.
Thanks for the review, addressed the comments here in v10.
https://lore.kernel.org/lkml/1714724287-12518-1-git-send-email-quic_mojha@quicinc.com/
-Mukesh
prev parent reply other threads:[~2024-05-03 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 14:13 [PATCH v9 1/3] soc: qcom: Add qcom_rproc_minidump module Mukesh Ojha
2024-03-26 14:13 ` [PATCH v9 2/3] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump() Mukesh Ojha
2024-03-26 14:13 ` [PATCH v9 3/3] remoteproc: qcom: Remove minidump related data from qcom_common.c Mukesh Ojha
2024-04-30 6:01 ` [PATCH v9 1/3] soc: qcom: Add qcom_rproc_minidump module Mukesh Ojha
2024-04-30 13:38 ` Bjorn Andersson
2024-05-03 8:27 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b7717c-1448-7f79-ea05-3dc9cc9bb90e@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_bjorande@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).