From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
freedreno@lists.freedesktop.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bryan O Donoghue <bryan.odonoghue@linaro.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>
Subject: [PATCH v2] arm64: dts: qcom: msm8998: enable adreno_smmu by default
Date: Wed, 15 May 2024 16:27:44 +0200 [thread overview]
Message-ID: <be51d1a4-e8fc-48d1-9afb-a42b1d6ca478@freebox.fr> (raw)
15 qcom platform DTSI files define an adreno_smmu node.
msm8998 is the only one with adreno_smmu disabled by default.
There's no reason why this SMMU should be disabled by default,
it doesn't need any further configuration.
Bring msm8998 in line with the 14 other platforms.
This fixes GPU init failing with ENODEV:
msm_dpu c901000.display-controller: failed to load adreno gpu
msm_dpu c901000.display-controller: failed to bind 5000000.gpu (ops a3xx_ops): -19
Fixes: 87cd46d68aeac8 ("Configure Adreno GPU and related IOMMU")
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
New in v2: rewrote commit message with input from Martin, Bryan, Luca
Supersedes: <1ba7031f-c97c-41f1-8cbc-d99f1e848e76@freebox.fr>
Maintainers, feel free to drop the Fixes tag.
Failure log:
[ 2.756363] [drm:adreno_bind] Found GPU: 5.4.0.1
[ 2.767183] [drm:a5xx_gpu_init]
[ 2.767422] [drm:adreno_gpu_init] fast_rate=710000097, slow_rate=27000000
[ 3.003869] [drm:msm_gpu_init] ebi1_clk: fffffffffffffffe
[ 3.004002] adreno 5000000.gpu: supply vdd not found, using dummy regulator
[ 3.008463] [drm:msm_gpu_init] gpu_reg: ffff0000819e4000
[ 3.015105] adreno 5000000.gpu: supply vddcx not found, using dummy regulator
[ 3.020702] [drm:msm_gpu_init] gpu_cx: ffff0000819e4180
[ 3.028173] [drm:adreno_iommu_create_address_space]
[ 3.054552] [drm:msm_gpu_init] gpu->aspace=ffffffffffffffed
[ 3.058112] [drm:a5xx_destroy] 5.4.0.1
[ 3.065922] [drm:msm_gpu_cleanup] 5.4.0.1
[ 3.074237] msm_dpu c901000.display-controller: failed to load adreno gpu
[ 3.082412] msm_dpu c901000.display-controller: failed to bind 5000000.gpu (ops a3xx_ops): -19
[ 3.088342] msm_dpu c901000.display-controller: [drm:drm_managed_release] drmres release begin
...
[ 3.197694] [drm:drm_managed_release] drmres release end
[ 3.204009] msm_dpu c901000.display-controller: adev bind failed: -19
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 3d3b1f61c0690..edf379c28e1e1 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -1580,7 +1580,6 @@ adreno_smmu: iommu@5040000 {
* SoC VDDMX RPM Power Domain in the Adreno driver.
*/
power-domains = <&gpucc GPU_GX_GDSC>;
- status = "disabled";
};
gpucc: clock-controller@5065000 {
--
2.34.1
next reply other threads:[~2024-05-15 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 14:27 Marc Gonzalez [this message]
2024-05-15 14:48 ` [PATCH v2] arm64: dts: qcom: msm8998: enable adreno_smmu by default Marijn Suijten
2024-05-17 15:09 ` Jeffrey Hugo
2024-05-28 3:32 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be51d1a4-e8fc-48d1-9afb-a42b1d6ca478@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=marijn.suijten@somainline.org \
--cc=phhusson@freebox.fr \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).