From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: <andersson@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <konrad.dybcio@linaro.org>,
<djakov@kernel.org>, <dmitry.baryshkov@linaro.org>,
<quic_anusha@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v11 0/6] Add interconnect driver for IPQ9574 SoC
Date: Sat, 4 May 2024 13:31:19 +0530 [thread overview]
Message-ID: <ZjXrTywO6+iRaEYk@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <20240430064214.2030013-1-quic_varada@quicinc.com>
Bjorn,
> On Tue, Apr 30, 2024 at 12:12:08PM +0530, Varadarajan Narayanan wrote:
> MSM platforms manage NoC related clocks and scaling from RPM.
> However, in IPQ SoCs, RPM is not involved in managing NoC
> related clocks and there is no NoC scaling.
>
> However, there is a requirement to enable some NoC interface
> clocks for the accessing the peripherals present in the
> system. Hence add a minimalistic interconnect driver that
> establishes a path from the processor/memory to those peripherals
> and vice versa.
>
> Change icc-clk driver to take master and slave ids instead
> of auto generating.
>
> Currently, drivers/clk/qcom/clk-cbf-8996.c is the only user of
> icc-clk. And, it had exactly one master and one slave node.
> For this the auto generated master (= 1) and slave (= 0) was
> enough.
>
> However, when drivers/clk/qcom/gcc-ipq9574.c wanted to make use
> of the icc-clk framework, it had more number of master and slave
> nodes and the auto generated ids did not suit the usage.
>
> ---
> v11: No code changes
> Commit log changed for the first patch
> Added Acked-By: to 3 patches
Can this be included in your driver changes for 6.10?
Thanks
Varada
> v10: Set gcc-ipq9574 driver's sync_state to icc_sync_state
> v9: Squash icc-clk driver change and cbf-msm8996 change
> Remove HWS_DATA macro
> v8: Change icc-clk driver to take master and slave ids instead
> of auto generating
> Remove ICC_xxx defines from dt-bindings header
> Define MASTER/SLAVE_xxx macros from 0 .. n
>
> v7: Fix macro names in dt-bindings header
> Do clock get in icc driver
>
> v6: Removed 'Reviewed-by: Krzysztof' from dt-bindings patch
> Remove clock get from ICC driver as suggested by Stephen Boyd
> so that the actual peripheral can do the clock get
> first_id -> icc_first_node_id
> Remove tristate from INTERCONNECT_CLK
> v5:
> Split gcc-ipq9574.c and common.c changes into separate patches
> Introduce devm_icc_clk_register
> Fix error handling
> v4:
> gcc-ipq9574.c
> Use clk_hw instead of indices
> common.c
> Do icc register in qcom_cc_probe() call stream
> common.h
> Add icc clock info to qcom_cc_desc structure
>
> v3:
> qcom,ipq9574.h
> Move 'first id' define to clock driver
> gcc-ipq9574.c:
> Use indexed identifiers here to avoid confusion
> Fix error messages and move code to common.c as it can be
> shared with future SoCs
>
> v2:
> qcom,ipq9574.h
> Fix license identifier
> Rename macros
> qcom,ipq9574-gcc.yaml
> Include interconnect-cells
> gcc-ipq9574.c
> Update commit log
> Remove IS_ENABLED(CONFIG_INTERCONNECT) and auto select it from Kconfig
> ipq9574.dtsi
> Moved to separate patch
> Include interconnect-cells to clock controller node
> drivers/clk/qcom/Kconfig:
> Auto select CONFIG_INTERCONNECT & CONFIG_INTERCONNECT_CLK
>
> Varadarajan Narayanan (6):
> interconnect: icc-clk: Specify master/slave ids
> dt-bindings: interconnect: Add Qualcomm IPQ9574 support
> interconnect: icc-clk: Add devm_icc_clk_register
> clk: qcom: common: Add interconnect clocks support
> clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks
> arm64: dts: qcom: ipq9574: Add icc provider ability to gcc
>
> .../bindings/clock/qcom,ipq9574-gcc.yaml | 3 +
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +
> drivers/clk/qcom/Kconfig | 2 +
> drivers/clk/qcom/clk-cbf-8996.c | 7 ++-
> drivers/clk/qcom/common.c | 35 ++++++++++-
> drivers/clk/qcom/common.h | 9 +++
> drivers/clk/qcom/gcc-ipq9574.c | 33 +++++++++++
> drivers/interconnect/icc-clk.c | 24 +++++++-
> .../dt-bindings/interconnect/qcom,ipq9574.h | 59 +++++++++++++++++++
> include/linux/interconnect-clk.h | 4 ++
> 10 files changed, 173 insertions(+), 5 deletions(-)
> create mode 100644 include/dt-bindings/interconnect/qcom,ipq9574.h
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-05-04 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 6:42 [PATCH v11 0/6] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 1/6] interconnect: icc-clk: Specify master/slave ids Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 2/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 3/6] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 4/6] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 5/6] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-04-30 6:42 ` [PATCH v11 6/6] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
2024-05-04 8:01 ` Varadarajan Narayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjXrTywO6+iRaEYk@hu-varada-blr.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).