From: Andi Shyti <andi.shyti@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-omap@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 00/15] i2c: use 'time_left' with wait_for_*
Date: Thu, 2 May 2024 13:29:38 +0200 [thread overview]
Message-ID: <6zrly2hk2vqljiuo3niehym74pqdgfv77fzjb63shgg4iiwhnt@zcnrqrke663b> (raw)
In-Reply-To: <20240427203611.3750-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On Sat, Apr 27, 2024 at 10:35:52PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
there was a little checkpatch warning here for the line being
over 75 characters, but I went ahead anyway and pushed the whole
series to i2c/i2c-host.
Thanks,
Andi
> store the result of wait_for_*() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
>
> This is the I2C part of a tree-wide series. The rest of the patches can
> be found here (slightly WIP):
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
>
> Because these patches are generated, they need manual audit. So, I will
> send them step by step. This is part 1 and also a call for opinions if
> this is a desirable change. But at least in the I2C realm, I really want
> to have it proper.
>
> Build bot is happy with these patches and I also compile tested them
> (except two). No functional changes intended.
>
> Wolfram Sang (15):
> i2c: amd-mp2-plat: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: digicolor: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: exynos5: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: hix5hd2: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: imx-lpi2c: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: omap: use 'time_left' variable with wait_for_completion_timeout()
> i2c: st: use 'time_left' variable with wait_for_completion_timeout()
> i2c: stm32f4: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: stm32f7: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: synquacer: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: jz4780: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: qcom-geni: use 'time_left' variable with
> wait_for_completion_timeout()
> i2c: rk3x: use 'time_left' variable with wait_event_timeout()
> i2c: s3c2410: use 'time_left' variable with wait_event_timeout()
> i2c: pxa: use 'time_left' variable with wait_event_timeout()
>
> --
> 2.43.0
>
prev parent reply other threads:[~2024-05-02 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 20:35 [PATCH 00/15] i2c: use 'time_left' with wait_for_* Wolfram Sang
2024-04-27 20:36 ` [PATCH 12/15] i2c: qcom-geni: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-04-29 10:52 ` Bryan O'Donoghue
2024-04-30 2:10 ` Bjorn Andersson
2024-04-30 0:07 ` [PATCH 00/15] i2c: use 'time_left' with wait_for_* Andi Shyti
2024-05-02 11:29 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6zrly2hk2vqljiuo3niehym74pqdgfv77fzjb63shgg4iiwhnt@zcnrqrke663b \
--to=andi.shyti@kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).