From: Connor Abbott <cwabbott0@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jun Nie <jun.nie@linaro.org>, Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
freedreno@lists.freedesktop.org,
Connor Abbott <cwabbott0@gmail.com>
Subject: [PATCH v3 0/6] drm/msm: Support a750 "software fuse" for raytracing
Date: Tue, 30 Apr 2024 11:43:14 +0100 [thread overview]
Message-ID: <20240430-a750-raytracing-v3-0-7f57c5ac082d@gmail.com> (raw)
On a750, Qualcomm decided to gate support for certain features behind a
"software fuse." This consists of a register in the cx_mem zone, which
is normally only writeable by the TrustZone firmware. On bootup it is
0, and we must call an SCM method to initialize it. Then we communicate
its value to userspace. This implements all of this, copying the SCM
call from the downstream kernel and kgsl.
So far the only optional feature we use is ray tracing (i.e. the
"ray_intersection" instruction) in a pending Mesa MR [1], so that's what
we expose to userspace. There's one extra patch to write some missing
registers, which depends on the register XML bump but is otherwise
unrelated, I just included it to make things easier on myself.
Note, 'drm/msm/a7xx: Initialize a750 "software fuse"' has a compile-time
dependency on 'firmware: qcom_scm: Add gpu_init_regs call' and it
depends on 'arm64: dts: qcom: sm8650: Fix GPU cx_mem size' to avoid a
boot-time hang. The commit the latter fixes, db33633b05c0 ("arm64: dts:
qcom: sm8650: add GPU nodes"), hasn't landed upstream yet, so we can
avoid regressions by merging it first. I think the rest of the series
can go through drm/msm for 6.10 after we land the first commit in the
same tree as db33633b05c0 to make sure linux-next is never broken,
although we'll need Bjorn's ack to land 'firmware: qcom_scm: Add
gpu_init_regs call' through drm/msm.
[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28447
Connor Abbott (6):
arm64: dts: qcom: sm8650: Fix GPU cx_mem size
firmware: qcom_scm: Add gpu_init_regs call
drm/msm: Update a6xx registers
drm/msm/a7xx: Initialize a750 "software fuse"
drm/msm: Add MSM_PARAM_RAYTRACING uapi
drm/msm/a7xx: Add missing register writes from downstream
arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
drivers/firmware/qcom/qcom_scm.c | 14 +++
drivers/firmware/qcom/qcom_scm.h | 3 +
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 97 ++++++++++++++++++-
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +
drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 28 +++++-
include/linux/firmware/qcom/qcom_scm.h | 23 +++++
include/uapi/drm/msm_drm.h | 1 +
9 files changed, 168 insertions(+), 5 deletions(-)
--
2.31.1
---
Changes in v3:
- Formatting/style fixes.
- Fix RB_CMP_DBG_ECO_CNTL write on a730/a740 and add comments from kgsl.
- Link to v2: https://lore.kernel.org/r/20240426-a750-raytracing-v2-0-562ac9866d63@gmail.com
---
Connor Abbott (6):
arm64: dts: qcom: sm8650: Fix GPU cx_mem size
firmware: qcom_scm: Add gpu_init_regs call
drm/msm: Update a6xx registers
drm/msm/a7xx: Initialize a750 "software fuse"
drm/msm: Add MSM_PARAM_RAYTRACING uapi
drm/msm/a7xx: Add missing register writes from downstream
arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
drivers/firmware/qcom/qcom_scm.c | 14 ++++
drivers/firmware/qcom/qcom_scm.h | 3 +
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 102 +++++++++++++++++++++++++-
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +
drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 28 ++++++-
include/linux/firmware/qcom/qcom_scm.h | 23 ++++++
include/uapi/drm/msm_drm.h | 1 +
9 files changed, 173 insertions(+), 5 deletions(-)
---
base-commit: 7e6b8924568d1aa476b77323df8d2bdd31bd7257
change-id: 20240426-a750-raytracing-dee7a526513b
Best regards,
--
Connor Abbott <cwabbott0@gmail.com>
next reply other threads:[~2024-04-30 10:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 10:43 Connor Abbott [this message]
2024-04-30 10:43 ` [PATCH v3 1/6] arm64: dts: qcom: sm8650: Fix GPU cx_mem size Connor Abbott
2024-05-02 8:03 ` Neil Armstrong
2024-04-30 10:43 ` [PATCH v3 2/6] firmware: qcom_scm: Add gpu_init_regs call Connor Abbott
2024-04-30 10:48 ` Konrad Dybcio
2024-05-27 0:03 ` Bjorn Andersson
2024-04-30 10:43 ` [PATCH v3 3/6] drm/msm: Update a6xx registers Connor Abbott
2024-04-30 10:43 ` [PATCH v3 4/6] drm/msm/a7xx: Initialize a750 "software fuse" Connor Abbott
2024-04-30 10:50 ` Konrad Dybcio
2024-04-30 10:43 ` [PATCH v3 5/6] drm/msm: Add MSM_PARAM_RAYTRACING uapi Connor Abbott
2024-04-30 10:43 ` [PATCH v3 6/6] drm/msm/a7xx: Add missing register writes from downstream Connor Abbott
2024-04-30 10:51 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430-a750-raytracing-v3-0-7f57c5ac082d@gmail.com \
--to=cwabbott0@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jun.nie@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).