Linux-ARM-Kernel Archive mirror
 help / color / mirror / Atom feed
From: Ravi Gunasekaran <r-gunasekaran@ti.com>
To: <nm@ti.com>, <vigneshr@ti.com>, <afd@ti.com>, <robh@kernel.org>,
	<rogerq@kernel.org>
Cc: <kristo@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<srk@ti.com>, <s-vadapalli@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Ravi Gunasekaran <r-gunasekaran@ti.com>
Subject: Re: [PATCH v2 1/3] arm64: dts: ti: k3-j722s-main: Add support for SERDES0
Date: Mon, 13 May 2024 17:19:16 +0530	[thread overview]
Message-ID: <f29f4d5f-b23e-5729-ea51-b8995171347f@ti.com> (raw)
In-Reply-To: <20240513114443.16350-2-r-gunasekaran@ti.com>

Roger,

On 5/13/24 5:14 PM, Ravi Gunasekaran wrote:
> AM62P's DT source files are reused for J722S inorder to
> avoid duplication of nodes. But J722S has additional
> peripherals that are not present in AM62P.
> 
> Introduce a -main.dtsi to define such additional main
> domain peripherals and define the SERDES0 node.
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> Changes since v1:
> ----------------
> * Newly introduced k3-j722s-main.dtsi to add main domain
>   peripherals that are additionally present in J722S
> 
> * Used generic node names - renamed "clock-cmnrefclk" to "clk-0",
>   "wiz@f000000" to "phy@f000000"
> 

[...]

> +
> +&cbass_main {
> +	serdes_wiz0: phy@f000000 {
> +		compatible = "ti,am64-wiz-10g";
> +		ranges = <0x0f000000 0x0 0x0f000000 0x00010000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		power-domains = <&k3_pds 279 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 279 0>, <&k3_clks 279 1>, <&serdes_refclk>;
> +		clock-names = "fck", "core_ref_clk", "ext_ref_clk";
> +		num-lanes = <1>;
> +		#reset-cells = <1>;
> +		#clock-cells = <1>;
> +
> +		assigned-clocks = <&k3_clks 279 1>;
> +		assigned-clock-parents = <&k3_clks 279 5>;
> +
> +		serdes0: serdes@f000000 {

[1] expects the node name to be "serdes". So I could not rename this node to "phy"
as discussed in the v1 series.

[1] - https://elixir.bootlin.com/linux/latest/source/drivers/phy/ti/phy-j721e-wiz.c#L1474

> +			compatible = "ti,j721e-serdes-10g";


[...]

-- 
Regards,
Ravi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-05-13 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 11:44 [PATCH v2 0/3] arm64: dts: ti: Add USB support for J722S EVM Ravi Gunasekaran
2024-05-13 11:44 ` [PATCH v2 1/3] arm64: dts: ti: k3-j722s-main: Add support for SERDES0 Ravi Gunasekaran
2024-05-13 11:49   ` Ravi Gunasekaran [this message]
2024-05-13 11:44 ` [PATCH v2 2/3] arm64: dts: ti: k3-j722s-main: Redefine USB1 node description Ravi Gunasekaran
2024-05-13 11:44 ` [PATCH v2 3/3] arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1 Ravi Gunasekaran
2024-05-24  5:44   ` Siddharth Vadapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f29f4d5f-b23e-5729-ea51-b8995171347f@ti.com \
    --to=r-gunasekaran@ti.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).