From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Julien Panis <jpanis@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Nicolas Pitre <npitre@baylibre.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
Date: Thu, 16 May 2024 11:08:38 +0200 [thread overview]
Message-ID: <f0a59da9-7b1a-4a11-bc3e-e39c9fa4e3bd@collabora.com> (raw)
In-Reply-To: <20240515-mtk-thermal-mt8188-mode-fix-v1-1-e656b310b67f@baylibre.com>
Il 15/05/24 17:03, Julien Panis ha scritto:
> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
Please add the relevant Fixes tag, after which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..82c355c466cf 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 1),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
> @@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(0, 1, 0, 0),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x200,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x300,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
>
> ---
> base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
> change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
>
> Best regards,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-05-16 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 15:03 [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
2024-05-15 15:22 ` Nicolas Pitre
2024-05-16 9:08 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a59da9-7b1a-4a11-bc3e-e39c9fa4e3bd@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=jpanis@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=npitre@baylibre.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).