From: James Clark <james.clark@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-perf-users@vger.kernel.org
Cc: gregkh@linuxfoundation.org, John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MAINTAINERS: perf: arm64: Catch all Arm files and folders
Date: Thu, 16 May 2024 12:36:21 +0200 [thread overview]
Message-ID: <ce6d7e6a-e24a-43b4-a9b8-4e946277c2d8@arm.com> (raw)
In-Reply-To: <e92a8423-9172-4aec-acbf-c9f136e6884f@arm.com>
On 16/05/2024 06:35, Anshuman Khandual wrote:
>
>
> On 5/15/24 20:42, James Clark wrote:
>> Catch all files and folders with Arm in the name in tools/perf/ up to
>> two levels deep. There currently no false positives.
>>
>> This catches lots of missing items like these and more:
>>
>> * util/arm-spe-decoder/
>> (The existing util/arm-spe* entry only matched files not folders)
>> * util/perf-regs-arch/perf_regs_arm.c
>> * scripts/python/arm-cs-trace-disasm.py
>> * tests/shell/test_arm_spe.sh
>
> Agreed.
>
>>
>> Signed-off-by: James Clark <james.clark@arm.com>
>> ---
>> MAINTAINERS | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ec0284125e8f..c5d0256d32dd 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -17318,9 +17318,10 @@ R: Leo Yan <leo.yan@linux.dev>
>> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> S: Supported
>> F: tools/build/feature/test-libopencsd.c
>> -F: tools/perf/arch/arm*/
>> -F: tools/perf/pmu-events/arch/arm64/
>> -F: tools/perf/util/arm-spe*
>> +F: tools/perf/*/*/*arm*
>> +F: tools/perf/*/*/*arm*/
>> +F: tools/perf/*/*arm*
>> +F: tools/perf/*/*arm*/
>> F: tools/perf/util/cs-etm*
>
> Very minor nit, these regular expressions should be arranged as per
> the increasing directory depth levels, just to make it apparent in
> terms of which files are being covered here ?
>
> F: tools/perf/*/*arm*
> F: tools/perf/*/*arm*/
> F: tools/perf/*/*/*arm*
> F: tools/perf/*/*/*arm*/
>
Checkpatch has an alphabetical sort which says they have to be the other
way around, but yes I agree I did write it your way initially.
> But regardless, with or without the above changes
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>
>>
>> PERSONALITY HANDLING
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-16 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 15:12 [PATCH] MAINTAINERS: perf: arm64: Catch all Arm files and folders James Clark
2024-05-16 4:35 ` Anshuman Khandual
2024-05-16 10:36 ` James Clark [this message]
2024-05-16 9:57 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce6d7e6a-e24a-43b4-a9b8-4e946277c2d8@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).