From: Ard Biesheuvel <ardb@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Thiago Jung Bauermann" <thiago.bauermann@linaro.org>,
"kernel test robot" <lkp@intel.com>, "Andrew Davis" <afd@ti.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Christian König" <christian.koenig@amd.com>,
"Eric DeVolder" <eric.devolder@oracle.com>,
"Rob Herring" <robh@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH] ARM: Do not select ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Wed, 15 May 2024 09:19:51 +0200 [thread overview]
Message-ID: <CAMj1kXE2h9MkPtaVcgUBvpK6e1NpzMfXN5GFdUmGSe2DNmg3VQ@mail.gmail.com> (raw)
In-Reply-To: <c65023fd-5f35-40f0-947d-377088919af3@sifive.com>
On Wed, 15 May 2024 at 00:48, Samuel Holland <samuel.holland@sifive.com> wrote:
>
> Hello Ard,
>
> On 2024-05-09 2:39 AM, Ard Biesheuvel wrote:
> > On Thu, 9 May 2024 at 03:37, Samuel Holland <samuel.holland@sifive.com> wrote:
> >>
> >> On 32-bit ARM, conversions between `double` and `long long` require
> >> runtime library support. Since the kernel does not currently provide
> >> this library support, the amdgpu driver fails to build:
> >>
> >> ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> >> ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> >>
> >> As Arnd reports, there are likely no 32-bit ARM platforms which can use
> >> the amdgpu driver anyway, due to lack of features like 64-bit
> >> prefetchable BARs. Since amdgpu is currently the only real user of
> >> ARCH_HAS_KERNEL_FPU_SUPPORT, drop support for this option instead of
> >> bothering to implement the library functions.
> >>
> >> Fixes: 12624fe2d707 ("ARM: implement ARCH_HAS_KERNEL_FPU_SUPPORT")
> >
> > This commit is not in mainline yet. Could we just drop the original
> > patch instead?
>
> No, like I mentioned in the original thread, later patches in the series (for
> example bbce5cac4f5a ("lib/raid6: use CC_FLAGS_FPU for NEON CFLAGS")) depend on
> CC_FLAGS_FPU being defined for both arm and arm64.
>
> arm can't select ARCH_HAS_KERNEL_FPU_SUPPORT because the contract of that option
> is not fully implemented, but in my opinion it doesn't hurt to keep the part
> that is implemented.
>
Fair enough. But that still doesn't mean we have to add the 'select
ARCH_HAS_KERNEL_FPU_SUPPORT' only to back it out again.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-05-15 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 1:37 [PATCH] ARM: Do not select ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-05-09 7:39 ` Ard Biesheuvel
2024-05-14 22:48 ` Samuel Holland
2024-05-15 7:19 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXE2h9MkPtaVcgUBvpK6e1NpzMfXN5GFdUmGSe2DNmg3VQ@mail.gmail.com \
--to=ardb@kernel.org \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=eric.devolder@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=tglx@linutronix.de \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).