Linux-ARM-Kernel Archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property
@ 2023-09-08  1:44 Fabio Estevam
  2023-09-08  1:44 ` [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-09-08  1:44 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, marcel.ziswiler, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.

Remove it to fix the following schema warning:

imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 -
 arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
index c6d51f116298..5438923a905c 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
@@ -165,7 +165,6 @@ &lsio_gpio5 {
 			  "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
 			  "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
 			  "gpio5-31";
-	ngpios = <32>;
 };
 
 /* Apalis PWM3, MXM3 pin 6 */
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
index 40067ab8aa74..72136c436a70 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
@@ -212,7 +212,6 @@ &lsio_gpio5 {
 			  "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
 			  "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
 			  "gpio5-31";
-	ngpios = <32>;
 };
 
 /* Apalis PWM3, MXM3 pin 6 */
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties
  2023-09-08  1:44 [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Fabio Estevam
@ 2023-09-08  1:44 ` Fabio Estevam
  2023-09-12 12:53   ` Marcel Ziswiler
  2023-09-12 12:53 ` [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Marcel Ziswiler
  2023-09-25  1:53 ` Shawn Guo
  2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2023-09-08  1:44 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, marcel.ziswiler, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per fsl-imx-gpio.yaml, 'pad-wakeup' and 'pad-wakeup-num' are not
valid properties/

Remove them to fix the following schema warning:

imx8qm-apalis-ixora-v1.1.dtb: gpio@5d0a0000: 'pad-wakeup', 'pad-wakeup-num' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 9b1b522517f8..7ce342007836 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -503,15 +503,6 @@ &lsio_gpio2 {
 			  "MXM3_185",
 			  "MXM3_187";
 
-	/*
-	 * Add GPIO2_20 as a wakeup source:
-	 * Pin:  101	SC_P_SPI3_CS0 (MXM3_37/WAKE1_MICO)
-	 * Type: 5	SC_PAD_WAKEUP_FALL_EDGE
-	 * Line: 20
-	 */
-	pad-wakeup = <IMX8QM_SPI3_CS0 5 20>;
-	pad-wakeup-num = <1>;
-
 	pcie-wifi-hog {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pcie_wifi_refclk>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property
  2023-09-08  1:44 [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Fabio Estevam
  2023-09-08  1:44 ` [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties Fabio Estevam
@ 2023-09-12 12:53 ` Marcel Ziswiler
  2023-09-25  1:53 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2023-09-12 12:53 UTC (permalink / raw)
  To: festevam@gmail.com, shawnguo@kernel.org
  Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de

On Thu, 2023-09-07 at 22:44 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.
> 
> Remove it to fix the following schema warning:
> 
> imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0-
> 9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 -
>  arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-
> apalis-ixora-v1.1.dtsi
> index c6d51f116298..5438923a905c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
> @@ -165,7 +165,6 @@ &lsio_gpio5 {
>                           "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
>                           "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
>                           "gpio5-31";
> -       ngpios = <32>;
>  };
>  
>  /* Apalis PWM3, MXM3 pin 6 */
> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-
> apalis-ixora-v1.2.dtsi
> index 40067ab8aa74..72136c436a70 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
> @@ -212,7 +212,6 @@ &lsio_gpio5 {
>                           "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
>                           "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
>                           "gpio5-31";
> -       ngpios = <32>;
>  };
>  
>  /* Apalis PWM3, MXM3 pin 6 */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties
  2023-09-08  1:44 ` [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties Fabio Estevam
@ 2023-09-12 12:53   ` Marcel Ziswiler
  0 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2023-09-12 12:53 UTC (permalink / raw)
  To: festevam@gmail.com, shawnguo@kernel.org
  Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de

On Thu, 2023-09-07 at 22:44 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fsl-imx-gpio.yaml, 'pad-wakeup' and 'pad-wakeup-num' are not
> valid properties/
> 
> Remove them to fix the following schema warning:
> 
> imx8qm-apalis-ixora-v1.1.dtb: gpio@5d0a0000: 'pad-wakeup', 'pad-wakeup-num' do not match any of the regexes:
> '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-
> v1.1.dtsi
> index 9b1b522517f8..7ce342007836 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
> @@ -503,15 +503,6 @@ &lsio_gpio2 {
>                           "MXM3_185",
>                           "MXM3_187";
>  
> -       /*
> -        * Add GPIO2_20 as a wakeup source:
> -        * Pin:  101    SC_P_SPI3_CS0 (MXM3_37/WAKE1_MICO)
> -        * Type: 5      SC_PAD_WAKEUP_FALL_EDGE
> -        * Line: 20
> -        */
> -       pad-wakeup = <IMX8QM_SPI3_CS0 5 20>;
> -       pad-wakeup-num = <1>;
> -
>         pcie-wifi-hog {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pinctrl_pcie_wifi_refclk>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property
  2023-09-08  1:44 [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Fabio Estevam
  2023-09-08  1:44 ` [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties Fabio Estevam
  2023-09-12 12:53 ` [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Marcel Ziswiler
@ 2023-09-25  1:53 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-09-25  1:53 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, marcel.ziswiler, Fabio Estevam

On Thu, Sep 07, 2023 at 10:44:28PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.
> 
> Remove it to fix the following schema warning:
> 
> imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-25  1:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-08  1:44 [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Fabio Estevam
2023-09-08  1:44 ` [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties Fabio Estevam
2023-09-12 12:53   ` Marcel Ziswiler
2023-09-12 12:53 ` [PATCH 1/2] arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property Marcel Ziswiler
2023-09-25  1:53 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).