From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
git@amd.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, harini.katakam@amd.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
michal.simek@amd.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATH net-next 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add clock support
Date: Thu, 16 May 2024 14:39:19 +0530 [thread overview]
Message-ID: <6bbc4606-67f4-4689-bd85-7de6b6f99a62@amd.com> (raw)
In-Reply-To: <4ae4d926-73f0-4f30-9d83-908a92046829@kernel.org>
Hi Krzysztof,
On 15/05/24 7:37 pm, Krzysztof Kozlowski wrote:
> On 15/05/2024 11:46, Vineeth Karumanchi wrote:
>> Add input clock support to gmii_to_rgmii IP.
>
> Why? Wasn't it there before?
Earlier we used to enable all PL clocks (fixed), now we want to enable
only the needed clocks.
>
>> Add "clocks" and "clock_names" bindings, "clkin" is the input clock name.
>
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch` helps here to create proper versioned patches.
> Another useful tool is b4. Skipping the PATCH keyword makes filtering of
> emails more difficult thus making the review process less convenient.
>
> Don't write it by yourself....
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
sorry mybad, I used 'git format-patch', but typo!.
Will take care from next time.
>>
>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>> ---
>> .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> index 0f781dac6717..d84d13fb2c54 100644
>> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> @@ -31,6 +31,13 @@ properties:
>> phy-handle:
>> $ref: ethernet-controller.yaml#/properties/phy-handle
>>
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: clkin
>> + description: 200/375 MHz free-running clock is used as a input clock.
>
> Nope, just write the description as items in clocks, instead of
> maxItems. And drop clock-names, not needed and kind of obvious.
>
OK.
🙏 vineeth
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-16 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:46 [PATH net-next 0/2] net: xilinx_gmii2rgmii: Add clock support Vineeth Karumanchi
2024-05-15 9:46 ` [PATH net-next 1/2] dt-bindings: " Vineeth Karumanchi
2024-05-15 14:07 ` Krzysztof Kozlowski
2024-05-16 9:09 ` Vineeth Karumanchi [this message]
2024-05-15 9:46 ` [PATH net-next 2/2] net: phy: xilinx-gmii2rgmii: Adopt " Vineeth Karumanchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bbc4606-67f4-4689-bd85-7de6b6f99a62@amd.com \
--to=vineeth.karumanchi@amd.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).