Linux-ARM-Kernel Archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/
@ 2021-06-25 13:27 Geert Uytterhoeven
  2021-06-25 13:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_SL3516 should depend on ARCH_GEMINI Geert Uytterhoeven
  2021-06-28  3:32 ` [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-06-25 13:27 UTC (permalink / raw
  To: Corentin Labbe, Herbert Xu, David S . Miller, Hans Ulli Kroll,
	Linus Walleij
  Cc: linux-crypto, linux-arm-kernel, Geert Uytterhoeven

From: Geert Uytterhoeven <geert+renesas@glider.be>

According to Documentation/devicetree/bindings/arm/gemini.txt, the
company was originally named "Storlink Semiconductor", and later renamed
to "Storm Semiconductor".

Fixes: 46c5338db7bd45b2 ("crypto: sl3516 - Add sl3516 crypto engine")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/crypto/Kconfig                   | 2 +-
 drivers/crypto/gemini/sl3516-ce-cipher.c | 2 +-
 drivers/crypto/gemini/sl3516-ce-core.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index ebcec460c045734f..8796ddf37cb5bfde 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -267,7 +267,7 @@ config CRYPTO_DEV_NIAGARA2
 	  checksumming, and raw copies.
 
 config CRYPTO_DEV_SL3516
-	tristate "Stormlink SL3516 crypto offloader"
+	tristate "Storlink SL3516 crypto offloader"
 	depends on HAS_IOMEM
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c
index b41c2f5fc495a856..c1c2b1d866639149 100644
--- a/drivers/crypto/gemini/sl3516-ce-cipher.c
+++ b/drivers/crypto/gemini/sl3516-ce-cipher.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * sl3516-ce-cipher.c - hardware cryptographic offloader for Stormlink SL3516 SoC
+ * sl3516-ce-cipher.c - hardware cryptographic offloader for Storlink SL3516 SoC
  *
  * Copyright (C) 2021 Corentin LABBE <clabbe@baylibre.com>
  *
diff --git a/drivers/crypto/gemini/sl3516-ce-core.c b/drivers/crypto/gemini/sl3516-ce-core.c
index da6cd529a6c01ff4..b7524b649068e980 100644
--- a/drivers/crypto/gemini/sl3516-ce-core.c
+++ b/drivers/crypto/gemini/sl3516-ce-core.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * sl3516-ce-core.c - hardware cryptographic offloader for Stormlink SL3516 SoC
+ * sl3516-ce-core.c - hardware cryptographic offloader for Storlink SL3516 SoC
  *
  * Copyright (C) 2021 Corentin Labbe <clabbe@baylibre.com>
  *
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] crypto: CRYPTO_DEV_SL3516 should depend on ARCH_GEMINI
  2021-06-25 13:27 [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Geert Uytterhoeven
@ 2021-06-25 13:27 ` Geert Uytterhoeven
  2021-06-28  3:32 ` [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-06-25 13:27 UTC (permalink / raw
  To: Corentin Labbe, Herbert Xu, David S . Miller, Hans Ulli Kroll,
	Linus Walleij
  Cc: linux-crypto, linux-arm-kernel, Geert Uytterhoeven

From: Geert Uytterhoeven <geert+renesas@glider.be>

The Storlink SL3516 crypto engine is only present on Storlink
Semiconductor/Storm Semiconductor/Cortina Systems Gemini SoCs.
Hence add a dependency on ARCH_GEMINI, to prevent asking the user about
this driver when configuring a kernel without Gemini support.

While at it, group the dependencies.

Fixes: 46c5338db7bd45b2 ("crypto: sl3516 - Add sl3516 crypto engine")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/crypto/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 8796ddf37cb5bfde..51690e73153ad443 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -268,13 +268,13 @@ config CRYPTO_DEV_NIAGARA2
 
 config CRYPTO_DEV_SL3516
 	tristate "Storlink SL3516 crypto offloader"
-	depends on HAS_IOMEM
+	depends on ARCH_GEMINI || COMPILE_TEST
+	depends on HAS_IOMEM && PM
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
 	select CRYPTO_ECB
 	select CRYPTO_AES
 	select HW_RANDOM
-	depends on PM
 	help
 	  This option allows you to have support for SL3516 crypto offloader.
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/
  2021-06-25 13:27 [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Geert Uytterhoeven
  2021-06-25 13:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_SL3516 should depend on ARCH_GEMINI Geert Uytterhoeven
@ 2021-06-28  3:32 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2021-06-28  3:32 UTC (permalink / raw
  To: Geert Uytterhoeven
  Cc: Corentin Labbe, David S . Miller, Hans Ulli Kroll, Linus Walleij,
	linux-crypto, linux-arm-kernel, Geert Uytterhoeven

On Fri, Jun 25, 2021 at 03:27:23PM +0200, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> According to Documentation/devicetree/bindings/arm/gemini.txt, the
> company was originally named "Storlink Semiconductor", and later renamed
> to "Storm Semiconductor".
> 
> Fixes: 46c5338db7bd45b2 ("crypto: sl3516 - Add sl3516 crypto engine")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/crypto/Kconfig                   | 2 +-
>  drivers/crypto/gemini/sl3516-ce-cipher.c | 2 +-
>  drivers/crypto/gemini/sl3516-ce-core.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-28  3:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-25 13:27 [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Geert Uytterhoeven
2021-06-25 13:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_SL3516 should depend on ARCH_GEMINI Geert Uytterhoeven
2021-06-28  3:32 ` [PATCH 1/2] crypto: Typo s/Stormlink/Storlink/ Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).