From: Manish Narani <manish.narani@xilinx.com>
To: <michal.simek@xilinx.com>, <adrian.hunter@intel.com>,
<ulf.hansson@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Manish Narani <manish.narani@xilinx.com>
Subject: [PATCH 4/7] mmc: host: sdhci-of-arasan: Check return value of non-void funtions
Date: Tue, 15 Jun 2021 16:13:54 +0530 [thread overview]
Message-ID: <1623753837-21035-5-git-send-email-manish.narani@xilinx.com> (raw)
In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com>
At a couple of places, the return values of the non-void functions were
not getting checked. This was reported by the coverity tool. Modify the
code to check the return values of the same.
Addresses-Coverity: ("check_return")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 1980d0b..98671a3 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -273,7 +273,12 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock)
* through low speeds without power cycling.
*/
sdhci_set_clock(host, host->max_clk);
- phy_power_on(sdhci_arasan->phy);
+ if (phy_power_on(sdhci_arasan->phy)) {
+ pr_err("%s: Cannot power on phy.\n",
+ mmc_hostname(host->mmc));
+ return;
+ }
+
sdhci_arasan->is_phy_on = true;
/*
@@ -323,7 +328,12 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock)
msleep(20);
if (ctrl_phy) {
- phy_power_on(sdhci_arasan->phy);
+ if (phy_power_on(sdhci_arasan->phy)) {
+ pr_err("%s: Cannot power on phy.\n",
+ mmc_hostname(host->mmc));
+ return;
+ }
+
sdhci_arasan->is_phy_on = true;
}
}
@@ -479,7 +489,9 @@ static int sdhci_arasan_suspend(struct device *dev)
ret = phy_power_off(sdhci_arasan->phy);
if (ret) {
dev_err(dev, "Cannot power off phy.\n");
- sdhci_resume_host(host);
+ if (sdhci_resume_host(host))
+ dev_err(dev, "Cannot resume host.\n");
+
return ret;
}
sdhci_arasan->is_phy_on = false;
--
2.1.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:43 [PATCH 0/7] sdhci-of-arasan driver updates for ZynqMP platform Manish Narani
2021-06-15 10:43 ` [PATCH 1/7] mmc: sdhci-of-arasan: Modified SD default speed to 19MHz for ZynqMP Manish Narani
2021-06-15 10:43 ` [PATCH 2/7] mmc: sdhci-of-arasan: Add "SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12" quirk Manish Narani
2021-06-15 10:43 ` [PATCH 3/7] mmc: sdhci-of-arasan: Skip Auto tuning for DDR50 mode in ZynqMP platform Manish Narani
2021-06-15 10:43 ` Manish Narani [this message]
2021-06-15 10:43 ` [PATCH 5/7] mmc: host: sdhci-of-arasan: Use appropriate type of division macro Manish Narani
2021-06-15 10:43 ` [PATCH 6/7] mmc: host: sdhci-of-arasan: Modify data type of the clk_phase array Manish Narani
2021-06-15 10:43 ` [PATCH 7/7] mmc: arasan: Fix the issue in reading tap values from DT Manish Narani
2021-06-22 15:07 ` [PATCH 0/7] sdhci-of-arasan driver updates for ZynqMP platform Adrian Hunter
2021-06-29 15:09 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623753837-21035-5-git-send-email-manish.narani@xilinx.com \
--to=manish.narani@xilinx.com \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).