From: Robin Murphy <robin.murphy@arm.com>
To: Namhyung Kim <namhyung@kernel.org>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Greg Thelen <gthelen@google.com>,
Tuan Phan <tuanphan@os.amperecomputing.com>
Subject: Re: [PATCH] perf/arm-dmc620: Fix lockdep assert in ->event_init()
Date: Wed, 15 May 2024 13:12:02 +0100 [thread overview]
Message-ID: <0a454227-ab99-4eb9-a736-1c826cfeb97d@arm.com> (raw)
In-Reply-To: <20240514180050.182454-1-namhyung@kernel.org>
On 2024-05-14 7:00 pm, Namhyung Kim wrote:
> for_each_sibling_event() checks leader's ctx but it doesn't have the ctx
> yet if it's the leader. Like in perf_event_validate_size(), we should
> skip checking siblings in that case.
Ugh, looking around for_each_sibling_event() sites, it looks like there
are a fair few other drivers using this pattern as well :(
I'd love for groups to be less horribly complicated, but I think I can
follow the underlying reasoning here. I suppose one could argue that the
assertion could take into account that there's nothing to protect in the
case where event->ctx is still NULL, since nobody else should be able to
touch the event's own empty sibling list at this point before
perf_event_open() has even returned. However by the same token there's
also no real reason for drivers *not* to return early when they equally
can tell that the sibling list must be empty, and indeed that seems to
be a fairly common pattern too, so I see no issue with fixing up all the
offending drivers for consistency either.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: f3c0eba287049 ("perf: Add a few assertions")
> Reported-by: Greg Thelen <gthelen@google.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Tuan Phan <tuanphan@os.amperecomputing.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> drivers/perf/arm_dmc620_pmu.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c
> index 8a81be2dd5ec..88c17c1d6d49 100644
> --- a/drivers/perf/arm_dmc620_pmu.c
> +++ b/drivers/perf/arm_dmc620_pmu.c
> @@ -542,12 +542,16 @@ static int dmc620_pmu_event_init(struct perf_event *event)
> if (event->cpu < 0)
> return -EINVAL;
>
> + hwc->idx = -1;
> +
> + if (event->group_leader == event)
> + return 0;
> +
> /*
> * We can't atomically disable all HW counters so only one event allowed,
> * although software events are acceptable.
> */
> - if (event->group_leader != event &&
> - !is_software_event(event->group_leader))
> + if (!is_software_event(event->group_leader))
> return -EINVAL;
>
> for_each_sibling_event(sibling, event->group_leader) {
> @@ -556,7 +560,6 @@ static int dmc620_pmu_event_init(struct perf_event *event)
> return -EINVAL;
> }
>
> - hwc->idx = -1;
> return 0;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-15 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 18:00 [PATCH] perf/arm-dmc620: Fix lockdep assert in ->event_init() Namhyung Kim
2024-05-15 12:12 ` Robin Murphy [this message]
2024-05-17 12:02 ` Will Deacon
2024-05-17 12:16 ` Robin Murphy
2024-05-17 12:17 ` Mark Rutland
2024-05-17 16:17 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a454227-ab99-4eb9-a736-1c826cfeb97d@arm.com \
--to=robin.murphy@arm.com \
--cc=gthelen@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tuanphan@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).