From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: Boqun Feng <boqun.feng@gmail.com>,
Puranjay Mohan <puranjay@kernel.org>,
Luc Maranget <luc.maranget@inria.fr>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Daniel Lustig <dlustig@nvidia.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
puranjay12@gmail.com
Subject: Re: [PATCH] tools/memory-model: Add atomic_and()/or()/xor() and add_negative
Date: Wed, 8 May 2024 16:46:35 -0700 [thread overview]
Message-ID: <8eaa61a3-4d27-4791-b98e-2a4cb331131c@paulmck-laptop> (raw)
In-Reply-To: <7e7167fd-cf4d-4d8b-bd83-d9fe8887dbae@gmail.com>
On Thu, May 09, 2024 at 06:59:17AM +0900, Akira Yokosawa wrote:
> On Wed, 8 May 2024 12:49:57 -0700, Boqun Feng wrote:
> > On Wed, May 08, 2024 at 02:34:00PM +0000, Puranjay Mohan wrote:
> >> Pull-849[1] added the support of '&', '|', and '^' to the herd7 tool's
> >> atomics operations.
> >>
> >> Use these in linux-kernel.def to implement atomic_and()/or()/xor() with
> >> all their ordering variants.
> >>
> >> atomic_add_negative() is already available so add its acquire, release,
> >> and relaxed ordering variants.
> >>
> >> [1] https://github.com/herd/herdtools7/pull/849
> >
> > A newer version of herd is required for this feature, right?
>
> Yes, this requires building herd7 from latest source.
>
> herdtools7 7.57 (released recently) happened before pull 849.
>
> Luc, what is your plan on a next release (7.57.1?) ?
>
> > So please
> > also do a change in tools/memory-model/README "REQUIREMENTS" session
> > when the new version released.
>
> Puranjay, it would be great if you add some litmus tests which use
> additional atomic primitives under tools/memory-model/litmus-tests/
> as well.
Thank you for checking, Akira! I need to hold off sending this upstream
until there is a herdtools7 release that supports it. So not the merge
window that is likely to open this weekend. ;-)
Thanx, Paul
> Thanks, Akira
>
> > Boqun
> >
> >>
> >> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> >> ---
> >> tools/memory-model/linux-kernel.def | 21 +++++++++++++++++++++
> >> 1 file changed, 21 insertions(+)
>
prev parent reply other threads:[~2024-05-08 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 14:34 [PATCH] tools/memory-model: Add atomic_and()/or()/xor() and add_negative Puranjay Mohan
2024-05-08 15:28 ` Andrea Parri
2024-05-08 17:34 ` Paul E. McKenney
2024-05-08 19:49 ` Boqun Feng
2024-05-08 21:59 ` Akira Yokosawa
2024-05-08 23:46 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eaa61a3-4d27-4791-b98e-2a4cb331131c@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=puranjay12@gmail.com \
--cc=puranjay@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).