From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400
Date: Fri, 15 Mar 2024 16:48:40 +0800 [thread overview]
Message-ID: <fee79370-b992-46a0-a675-80b913d48e05@amlogic.com> (raw)
In-Reply-To: <1jcyrxi2l0.fsf@starbuckisacylon.baylibre.com>
Hi Jerome,
Thanks for your reply.
On 2024/3/14 17:26, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
>
> On Thu 14 Mar 2024 at 16:08, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
>>>> +
>>>> +#include "amlogic-a4.dtsi"
>>> Could you describe how the a4 and a5 differs from each other ?
>>> The description given in the commit description is the same.
>>> Beside the a53 vs a55, I'm not seeing much of a difference.
>>> Admittedly, there is not much yet but I wonder if a4 and a5 should have
>>> a common dtsi.
>>>
>> They are mostly the same, A5 include HiFi-DSP and NPU, but A4 is not. And
>> some peripheral modules are different, such as SPI and Ehernet phy.
>>
>> I would like to wait for the follow-on chips to come out before considering
>> a merger with common dtsi file.
>>
>
> No, Please do it now. There is no reason for the community to review the
> same thing twice if the SoCs are "mostly the same".
>
OK, I will do it.
>>>> +
>>>> +/ {
>>>> + model = "Amlogic A113L2 ba400 Development Board";
>>>> + compatible = "amlogic,ba400","amlogic,a4";
>>>> + interrupt-parent = <&gic>;
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> +
>>>> + aliases {
>>>> + serial0 = &uart_b;
>>>> + };
>>>> +
>>>> + memory@0 {
>>>> + device_type = "memory";
>>>> + reg = <0x0 0x0 0x0 0x40000000>;
>>>> + };
>>>> +
>>>> + reserved-memory {
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> + ranges;
>>>> +
>>>> + /* 52 MiB reserved for ARM Trusted Firmware */
>>> That's a lot of memory to blindly reserve.
>>> Any chance we can stop doing that and have u-boot amend reserved memory
>>> zone based on the actual needs of the device ?
>> Yes. U-boot will change size of reserved memory base on actual usage.
>
> Then u-boot should add (not change) the memory if necessary.
> Please drop this.
>
Amlogic's u-boot will change the reserved memory size, size is not an
issue. But Some one use u-boot himself not Amlogic's, If here drop this,
there is a strange problem when it runs.
>>>
>>>> + secmon_reserved:linux,secmon {
>>>> + compatible = "shared-dma-pool";
>>>> + no-map;
>>>> + alignment = <0x0 0x400000>;
>>>> + reg = <0x0 0x05000000 0x0 0x3400000>;
>>>> + };
>>>> + };
>>>> +};
>>>> +
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-03-15 8:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 9:18 [PATCH 0/4] Baisc devicetree support for Amlogic A4 and A5 Xianwei Zhao via B4 Relay
2024-03-12 9:18 ` [PATCH 1/4] dt-bindings: arm: amlogic: add A4 support Xianwei Zhao via B4 Relay
2024-03-12 11:06 ` Krzysztof Kozlowski
2024-03-12 17:20 ` Martin Blumenstingl
2024-03-13 9:44 ` Xianwei Zhao
2024-03-12 9:18 ` [PATCH 2/4] dt-bindings: arm: amlogic: add A5 support Xianwei Zhao via B4 Relay
2024-03-12 11:06 ` Krzysztof Kozlowski
2024-03-12 17:21 ` Martin Blumenstingl
2024-03-13 9:48 ` Xianwei Zhao
2024-03-12 9:18 ` [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400 Xianwei Zhao via B4 Relay
2024-03-12 9:55 ` Jerome Brunet
2024-03-14 8:08 ` Xianwei Zhao
2024-03-14 9:26 ` Jerome Brunet
2024-03-15 8:48 ` Xianwei Zhao [this message]
2024-03-12 11:07 ` Krzysztof Kozlowski
2024-03-13 11:15 ` Xianwei Zhao
2024-03-12 17:29 ` Martin Blumenstingl
2024-03-14 3:04 ` Xianwei Zhao
2024-03-13 9:53 ` [DMARC error][DKIM error] " Dmitry Rokosov
2024-03-14 5:19 ` Xianwei Zhao
2024-03-14 6:58 ` Krzysztof Kozlowski
2024-03-15 3:13 ` Xianwei Zhao
2024-03-14 9:04 ` Neil Armstrong
2024-03-15 1:16 ` Xianwei Zhao
2024-03-12 9:19 ` [PATCH 4/4] arm64: dts: add support for A5 based Amlogic AV400 Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee79370-b992-46a0-a675-80b913d48e05@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).