* [PATCH] serial: meson: remove redundant initialization of variable id
@ 2021-04-26 10:11 Colin King
2021-04-26 15:18 ` Kevin Hilman
2021-04-27 18:31 ` Martin Blumenstingl
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-04-26 10:11 UTC (permalink / raw
To: Greg Kroah-Hartman, Jiri Slaby, Kevin Hilman, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, linux-serial,
linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable id being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed. Since id is just being used in a for-loop
inside a local scope, move the declaration of id to that scope.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/tty/serial/meson_uart.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 529cd0289056..d7f55031b2cf 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -716,12 +716,13 @@ static int meson_uart_probe(struct platform_device *pdev)
struct resource *res_mem, *res_irq;
struct uart_port *port;
int ret = 0;
- int id = -1;
if (pdev->dev.of_node)
pdev->id = of_alias_get_id(pdev->dev.of_node, "serial");
if (pdev->id < 0) {
+ int id;
+
for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) {
if (!meson_ports[id]) {
pdev->id = id;
--
2.30.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: meson: remove redundant initialization of variable id
2021-04-26 10:11 [PATCH] serial: meson: remove redundant initialization of variable id Colin King
@ 2021-04-26 15:18 ` Kevin Hilman
2021-04-27 18:31 ` Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2021-04-26 15:18 UTC (permalink / raw
To: Colin King, Greg Kroah-Hartman, Jiri Slaby, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, linux-serial,
linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable id being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed. Since id is just being used in a for-loop
> inside a local scope, move the declaration of id to that scope.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/tty/serial/meson_uart.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 529cd0289056..d7f55031b2cf 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -716,12 +716,13 @@ static int meson_uart_probe(struct platform_device *pdev)
> struct resource *res_mem, *res_irq;
> struct uart_port *port;
> int ret = 0;
> - int id = -1;
>
> if (pdev->dev.of_node)
> pdev->id = of_alias_get_id(pdev->dev.of_node, "serial");
>
> if (pdev->id < 0) {
> + int id;
> +
> for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) {
> if (!meson_ports[id]) {
> pdev->id = id;
> --
> 2.30.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: meson: remove redundant initialization of variable id
2021-04-26 10:11 [PATCH] serial: meson: remove redundant initialization of variable id Colin King
2021-04-26 15:18 ` Kevin Hilman
@ 2021-04-27 18:31 ` Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2021-04-27 18:31 UTC (permalink / raw
To: Colin King
Cc: Greg Kroah-Hartman, Jiri Slaby, Kevin Hilman, Neil Armstrong,
Jerome Brunet, linux-serial, linux-arm-kernel, linux-amlogic,
kernel-janitors, linux-kernel
On Mon, Apr 26, 2021 at 12:11 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable id being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed. Since id is just being used in a for-loop
> inside a local scope, move the declaration of id to that scope.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-27 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 10:11 [PATCH] serial: meson: remove redundant initialization of variable id Colin King
2021-04-26 15:18 ` Kevin Hilman
2021-04-27 18:31 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).