From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: <neil.armstrong@linaro.org>
Cc: <jbrunet@baylibre.com>, <mturquette@baylibre.com>,
<khilman@baylibre.com>, <martin.blumenstingl@googlemail.com>,
<glaroque@baylibre.com>, <rafael@kernel.org>,
<daniel.lezcano@linaro.org>, <rui.zhang@intel.com>,
<lukasz.luba@arm.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<kernel@salutedevices.com>, <rockosov@gmail.com>,
<linux-amlogic@lists.infradead.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: thermal: amlogic: add support for A1 thermal sensor
Date: Thu, 28 Mar 2024 17:29:06 +0300 [thread overview]
Message-ID: <20240328142818.5mnktmaq2dctos6o@CAB-WSD-L081021> (raw)
In-Reply-To: <19897482-2fa1-4688-aeec-855123558374@linaro.org>
Hello Neil,
Thank you for quick feedback.
On Thu, Mar 28, 2024 at 03:07:52PM +0100, neil.armstrong@linaro.org wrote:
> Hi,
>
> On 28/03/2024 14:37, Dmitry Rokosov wrote:
> > Provide right compatible properties for Amlogic A1 Thermal Sensor
> > controller. A1 family supports only one thermal node - CPU thermal
> > sensor.
> >
> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> > ---
> > .../bindings/thermal/amlogic,thermal.yaml | 14 +++++++++-----
> > 1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> > index 20f8f9b3b971..0e7f6568d385 100644
> > --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> > @@ -13,11 +13,15 @@ description: Binding for Amlogic Thermal
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - amlogic,g12a-cpu-thermal
> > - - amlogic,g12a-ddr-thermal
> > - - const: amlogic,g12a-thermal
> > + oneOf:
> > + - items:
> > + - enum:
> > + - amlogic,g12a-cpu-thermal
> > + - amlogic,g12a-ddr-thermal
> > + - const: amlogic,g12a-thermal
> > + - items:
> > + - const: amlogic,a1-cpu-thermal
> > + - const: amlogic,a1-thermal
>
> In this case you can just use "amlogic,a1-cpu-thermal" or "amlogic,a1-thermal", no need for a fallback.
Okay, I will send v2 with only one compatible w/o fallback.
--
Thank you,
Dmitry
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-03-28 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 13:37 [PATCH v1 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller Dmitry Rokosov
2024-03-28 13:37 ` [PATCH v1 1/2] dt-bindings: thermal: amlogic: add support for A1 thermal sensor Dmitry Rokosov
2024-03-28 14:07 ` neil.armstrong
2024-03-28 14:29 ` Dmitry Rokosov [this message]
2024-03-28 13:37 ` [PATCH v1 2/2] thermal: amlogic: support A1 SoC family Thermal Sensor controller Dmitry Rokosov
2024-03-28 14:08 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328142818.5mnktmaq2dctos6o@CAB-WSD-L081021 \
--to=ddrokosov@salutedevices.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).