From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csg>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>
On Mon, 6 Mar 2023, Alexandre Ghiti wrote:
> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */
You can't just remove a UAPI header like this, something will break; cf.
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if
you want it brief.
I suggest that you fold it into 01/26 (it makes no sense to have empty
multiple inclusion protection), and likewise for the relevant remaining
headers.
Maciej
prev parent reply other threads:[~2023-05-16 0:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230306100508.1171812-1-alexghiti@rivosinc.com>
2023-03-06 10:04 ` [PATCH v5 01/26] alpha: Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 02/26] arm64: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 03/26] arm: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 04/26] ia64: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 05/26] m68k: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 06/26] microblaze: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 07/26] mips: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 08/26] parisc: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 09/26] powerpc: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 10/26] sparc: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 11/26] xtensa: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 12/26] riscv: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 13/26] asm-generic: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h> Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 15/26] arc: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 16/26] m68k: " Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 17/26] arm64: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 18/26] microblaze: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 19/26] sparc: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 20/26] parisc: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 21/26] x86: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 22/26] xtensa: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 23/26] powerpc: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 24/26] mips: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 25/26] s390: " Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 26/26] riscv: " Alexandre Ghiti
2023-03-06 13:19 ` [PATCH v5 00/26] Remove COMMAND_LINE_SIZE from uapi Philippe Mathieu-Daudé
2023-05-09 7:06 ` Alexandre Ghiti
[not found] ` <20230306100508.1171812-15-alexghiti@rivosinc.com>
2023-05-16 0:53 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alexghiti@rivosinc.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csg \
--cc=corbet@lwn.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=kernel@xen0n.name \
--cc=linux@armlinux.org.uk \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).