From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
3chas3@gmail.com, brking@us.ibm.com, dalias@libc.org,
glaubitz@physik.fu-berlin.de, ink@jurassic.park.msu.ru,
jejb@linux.ibm.com, kw@linux.com, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-atm-general@lists.sourceforge.net,
linux-scsi@vger.kernel.org, linux-sh@vger.kernel.org,
lpieralisi@kernel.org, martin.petersen@oracle.com,
mattst88@gmail.com, Netdev <netdev@vger.kernel.org>,
richard.henderson@linaro.org, toan@os.amperecomputing.com,
ysato@users.sourceforge.jp,
Tadeusz Struk <tadeusz.struk@intel.com>
Subject: Re: [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling
Date: Wed, 11 Oct 2023 14:07:18 +0300 (EEST) [thread overview]
Message-ID: <667e1068-20c3-938f-2d87-fb1d6c44a45e@linux.intel.com> (raw)
In-Reply-To: <20231010223530.GA1005985@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 2847 bytes --]
On Tue, 10 Oct 2023, Bjorn Helgaas wrote:
> [+cc Tadeusz; updates to quirk_intel_qat_vf_cap()]
>
> On Mon, Sep 11, 2023 at 03:53:48PM +0300, Ilpo Järvinen wrote:
> > As the first step towards converting PCI accessor function return codes
> > into normal errnos this series cleans up related code paths which have
> > complicated multi-line construct to handle the PCI error checking.
> >
> > I'd prefer these (the remaining ones) to be routed through PCI tree due
> > to PCI accessor function return code conversion being built on top of
> > them.
> >
> > v3:
> > - Return pci_generic_config_read32()'s error code directly
> > - Removed already accepted patches
> >
> > v2:
> > - Moved ret local var to the inner block (I2C: ali15x3)
> > - Removed already accepted patches
> >
> >
> > Ilpo Järvinen (6):
> > alpha: Streamline convoluted PCI error handling
> > sh: pci: Do PCI error check on own line
> > atm: iphase: Do PCI error checks on own line
> > PCI: Do error check on own line to split long if conditions
> > PCI: xgene: Do PCI error check on own line & keep return value
> > scsi: ipr: Do PCI error checks on own line
> >
> > arch/alpha/kernel/sys_miata.c | 17 +++++++++--------
> > arch/sh/drivers/pci/common.c | 7 ++++---
> > drivers/atm/iphase.c | 20 +++++++++++---------
> > drivers/pci/controller/pci-xgene.c | 7 ++++---
> > drivers/pci/pci.c | 9 ++++++---
> > drivers/pci/probe.c | 6 +++---
> > drivers/pci/quirks.c | 6 +++---
> > drivers/scsi/ipr.c | 12 ++++++++----
> > 8 files changed, 48 insertions(+), 36 deletions(-)
>
> Applied all to pci/config-errs for v6.7, thanks!
>
> I made the tweaks below; heads-up to John Paul and Tadeusz.
>
> Oh, and weird experience applying these via b4, git am: the
> Signed-off-by was corrupted on these patches:
>
> https://lore.kernel.org/r/20230911125354.25501-7-ilpo.jarvinen@linux.intel.com https://lore.kernel.org/r/20230911125354.25501-6-ilpo.jarvinen@linux.intel.com https://lore.kernel.org/r/20230911125354.25501-3-ilpo.jarvinen@linux.intel.com
>
> It looked like this:
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> Not sure why this happened; maybe one of the mailing lists screwed it
> up and the order of arrival determines which one b4 uses? The ones
> from linux-alpha look like:
>
> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
>
> which I think corresponds to the bad rendering. I think I fixed them
> all.
Thanks for letting me know. It seems that copies of the same mail
https://lore.kernel.org/linux-alpha/...
https://lore.kernel.org/linux-pci/...
do indeed differ for some reason. I'll probably have to experiment to see
if I can reproduce problem with the linux-alpha list.
--
i.
prev parent reply other threads:[~2023-10-11 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 12:53 [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 1/6] alpha: Streamline convoluted PCI error handling Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 2/6] sh: pci: Do PCI error check on own line Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 3/6] atm: iphase: Do PCI error checks " Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 4/6] PCI: Do error check on own line to split long if conditions Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 5/6] PCI: xgene: Do PCI error check on own line & keep return value Ilpo Järvinen
2023-09-11 12:53 ` [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line Ilpo Järvinen
2023-09-14 1:00 ` Martin K. Petersen
2023-10-10 22:35 ` [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling Bjorn Helgaas
2023-10-11 11:07 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667e1068-20c3-938f-2d87-fb1d6c44a45e@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=3chas3@gmail.com \
--cc=brking@us.ibm.com \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=helgaas@kernel.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jejb@linux.ibm.com \
--cc=kw@linux.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mattst88@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richard.henderson@linaro.org \
--cc=robh@kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=toan@os.amperecomputing.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).