From: Randy Dunlap <rdunlap@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>
Cc: linux-alpha@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Alpha MTD_TSUNAMI BROKEN?
Date: Tue, 21 Feb 2023 21:37:21 -0800 [thread overview]
Message-ID: <4da501dc-65af-ee89-441d-d3ef8867c64d@infradead.org> (raw)
Hi,
In an alpha kernel config with CONFIG_ALPHA_TSUNAMI=y
and CONFIG_MTD_TSUNAMI=y, the MTD driver build fails with:
../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_read8':
../drivers/mtd/maps/tsunami_flash.c:21:20: error: implicit declaration of function 'tsunami_tig_readb'; did you mean 'tsunami_readb'? [-Werror=implicit-function-declaration]
21 | val.x[0] = tsunami_tig_readb(offset);
| ^~~~~~~~~~~~~~~~~
| tsunami_readb
../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_write8':
../drivers/mtd/maps/tsunami_flash.c:27:9: error: implicit declaration of function 'tsunami_tig_writeb'; did you mean 'tsunami_writeb'? [-Werror=implicit-function-declaration]
27 | tsunami_tig_writeb(value.x[0], offset);
| ^~~~~~~~~~~~~~~~~~
| tsunami_writeb
The tsunami_tig_{readb,writeb{}() functions are completely missing.
I don't see any macros that would generate such function names.
I have searched both kernel/git/history/history.git and
kernel/git/mpe/linux-fullhistory.git (both at git.kernel.org)
and found no such functions. (It's possible that I could have
missed something here: all I did was 'git grep tsunami_tig'.
Do I need to do 'git checkout <something really old>' first?)
Should these functions just be tsunami_readb() and tsunami_writeb()
like the compiler asks?
Or should we mark this driver as BROKEN?
Thanks.
--
~Randy
reply other threads:[~2023-02-22 5:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da501dc-65af-ee89-441d-d3ef8867c64d@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).