From: kernel test robot <lkp@intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozla
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Miguel Ojeda <ojeda@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()
Date: Fri, 17 Mar 2023 03:03:04 +0800 [thread overview]
Message-ID: <202303170223.V0xQhs1V-lkp@intel.com> (raw)
In-Reply-To: <20230314192634.63531-2-andriy.shevchenko@linux.intel.com>
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus powerpc/next powerpc/fixes linus/master v6.3-rc2 next-20230316]
[cannot apply to soc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20230314192634.63531-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()
config: powerpc-randconfig-r032-20230312 (https://download.01.org/0day-ci/archive/20230317/202303170223.V0xQhs1V-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821
git checkout 85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303170223.V0xQhs1V-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/powerpc/platforms/52xx/mpc52xx_pci.c:331:6: error: unused variable 'i' [-Werror,-Wunused-variable]
int i;
^
1 error generated.
vim +/i +331 arch/powerpc/platforms/52xx/mpc52xx_pci.c
f42963f8646540 Grant Likely 2006-12-12 326
f42963f8646540 Grant Likely 2006-12-12 327 static void
f42963f8646540 Grant Likely 2006-12-12 328 mpc52xx_pci_fixup_resources(struct pci_dev *dev)
f42963f8646540 Grant Likely 2006-12-12 329 {
85cdf4746b716f Mika Westerberg 2023-03-14 330 struct resource *res;
f42963f8646540 Grant Likely 2006-12-12 @331 int i;
f42963f8646540 Grant Likely 2006-12-12 332
59510820fff76f Randy Dunlap 2021-04-28 333 pr_debug("%s() %.4x:%.4x\n", __func__, dev->vendor, dev->device);
f42963f8646540 Grant Likely 2006-12-12 334
f42963f8646540 Grant Likely 2006-12-12 335 /* We don't rely on boot loader for PCI and resets all
f42963f8646540 Grant Likely 2006-12-12 336 devices */
85cdf4746b716f Mika Westerberg 2023-03-14 337 pci_dev_for_each_resource_p(dev, res) {
f42963f8646540 Grant Likely 2006-12-12 338 if (res->end > res->start) { /* Only valid resources */
f42963f8646540 Grant Likely 2006-12-12 339 res->end -= res->start;
f42963f8646540 Grant Likely 2006-12-12 340 res->start = 0;
f42963f8646540 Grant Likely 2006-12-12 341 res->flags |= IORESOURCE_UNSET;
f42963f8646540 Grant Likely 2006-12-12 342 }
f42963f8646540 Grant Likely 2006-12-12 343 }
f42963f8646540 Grant Likely 2006-12-12 344
f42963f8646540 Grant Likely 2006-12-12 345 /* The PCI Host bridge of MPC52xx has a prefetch memory resource
f42963f8646540 Grant Likely 2006-12-12 346 fixed to 1Gb. Doesn't fit in the resource system so we remove it */
f42963f8646540 Grant Likely 2006-12-12 347 if ( (dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
f42963f8646540 Grant Likely 2006-12-12 348 ( dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
f42963f8646540 Grant Likely 2006-12-12 349 || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B) ) {
f42963f8646540 Grant Likely 2006-12-12 350 struct resource *res = &dev->resource[1];
f42963f8646540 Grant Likely 2006-12-12 351 res->start = res->end = res->flags = 0;
f42963f8646540 Grant Likely 2006-12-12 352 }
f42963f8646540 Grant Likely 2006-12-12 353 }
f42963f8646540 Grant Likely 2006-12-12 354
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-16 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 19:26 [PATCH v5 0/4] PCI: Add pci_dev_for_each_resource() helper and update users Andy Shevchenko
2023-03-14 19:26 ` [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource() Andy Shevchenko
2023-03-16 19:03 ` kernel test robot [this message]
2023-03-14 19:26 ` [PATCH v5 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() Andy Shevchenko
2023-03-14 19:26 ` [PATCH v5 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Andy Shevchenko
2023-03-14 19:26 ` [PATCH v5 4/4] pcmcia: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303170223.V0xQhs1V-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=helgaas@kernel.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jgross@suse.com \
--cc=kw@linux.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozla \
--cc=llvm@lists.linux.dev \
--cc=macro@orcam.me.uk \
--cc=mattst88@gmail.com \
--cc=mic@digikod.net \
--cc=mika.westerberg@linux.intel.com \
--cc=mpe@ellerman.id.au \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=pali@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).