From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Ben Cheatham <Benjamin.Cheatham@amd.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK
Date: Tue, 30 Apr 2024 12:00:53 -0700 [thread overview]
Message-ID: <ZjE/5VW95v54Tv94@aschofie-mobl2> (raw)
In-Reply-To: <ZhgPe5mDt2ocXovz@aschofie-mobl2>
On Thu, Apr 11, 2024 at 09:27:39AM -0700, Alison Schofield wrote:
> On Thu, Apr 11, 2024 at 08:24:43AM +0200, Lukas Bulwahn wrote:
> > Commit 12fb28ea6b1c ("EINJ: Add CXL error type support") adds the header
> > file include/linux/einj-cxl.h, but then adds a file entry with cxl-einj.h
> > (note the swapping of words) to the COMPUTE EXPRESS LINK (CXL) section.
> >
> > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> > broken reference.
> >
> > Repair the file entry in COMPUTE EXPRESS LINK (CXL).
>
> How about stating the impact, something like:
>
> get_maintainer.pl can only return commit_signer history for file
> include/linux/einj-cxl.h because the entry in MAINTAINERS is wrong.
> Correct the entry so that the full MAINTAINER list is returned.
Hi Dave,
Perhaps you can amend the commit log with this suggestion upon applying.
With that done, you can add:
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> It is interesting how you found it and I'm not suggesting deleting
> that.
>
> Thanks,
> Alison
>
>
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> > ---
> > MAINTAINERS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index edf6176a5530..03204db05027 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5415,7 +5415,7 @@ M: Dan Williams <dan.j.williams@intel.com>
> > L: linux-cxl@vger.kernel.org
> > S: Maintained
> > F: drivers/cxl/
> > -F: include/linux/cxl-einj.h
> > +F: include/linux/einj-cxl.h
> > F: include/linux/cxl-event.h
> > F: include/uapi/linux/cxl_mem.h
> > F: tools/testing/cxl/
> > --
> > 2.44.0
> >
> >
>
prev parent reply other threads:[~2024-04-30 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 6:24 [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK Lukas Bulwahn
2024-04-11 16:27 ` Alison Schofield
2024-04-30 19:00 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjE/5VW95v54Tv94@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).