From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: albanhuang <albanhuang0@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com,
linux-acpi@vger.kernel.org, tony@atomide.com,
john.ogness@linutronix.de, yangyicong@hisilicon.com,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, lvjianmin@loongson.cn,
albanhuang@tencent.com, tombinfan@tencent.com
Subject: Re: [PATCH v6 0/3] serial: 8250_pnp: Support configurable reg shift property
Date: Wed, 10 Apr 2024 16:40:44 +0300 [thread overview]
Message-ID: <ZhaW3PM3TccV5t3w@smile.fi.intel.com> (raw)
In-Reply-To: <4f0950f8-e0e1-4b26-85b9-385c97c39cf6@gmail.com>
On Wed, Apr 10, 2024 at 10:49:29AM +0800, albanhuang wrote:
> 在 2024/4/9 20:53, Andy Shevchenko 写道:
> > On Tue, Apr 09, 2024 at 03:43:20PM +0800, Guanbing Huang wrote:
> > > From: Guanbing Huang <albanhuang@tencent.com>
> > >
> > > The 16550a serial port based on the ACPI table requires obtaining the
> > > reg-shift attribute. In the ACPI scenario, If the reg-shift property
> > > is not configured like in DTS, the 16550a serial driver cannot read or
> > > write controller registers properly during initialization.
> > >
> > > To address the issue of configuring the reg-shift property, the
> > > __uart_read_properties() universal interface is called to implement it.
> > > Adaptation of PNP devices is done in the __uart_read_properties() function.
> > You either forgot or deliberately not added my tag. Can you elaborate?
>
> I'm very sorry, this is my first time submitting a kernel patch. My
> understanding
>
> of the submission specification is not comprehensive and profound enough,
>
> and I didn't intentionally not add tags. I hope you can forgive my
> operational mistake.
>
> Should I just add a "Reviewed-by tag", or do I need any other tags? Thanks.
Understood. So if you are is one who is sending a new version, you should take
care about any given tags (such as Reviewed-by) and carry them, in case the
code is not drastically changed. I.o.w. if you don't, you have to explain why.
Anyways, it seems the patch still has a flaw as per LKP, so fix that by
providing probably two macros in the pnp.h header for both cases
(CONFIG_PNP=y/n), and I will review it again.
#ifdef CONFIG_PNP
...
#define dev_is_pnp(...) ...
...
#else
...
#define dev_is_pnp(...) false
...
#endif
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-10 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 7:43 [PATCH v6 0/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
2024-04-09 7:43 ` [PATCH v6 1/3] PNP: Add dev_is_pnp() macro Guanbing Huang
2024-04-09 7:44 ` [PATCH v6 2/3] serial: port: Add support of PNP IRQ to __uart_read_properties() Guanbing Huang
2024-04-09 21:37 ` kernel test robot
2024-04-09 21:48 ` kernel test robot
2024-04-09 7:44 ` [PATCH v6 3/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
2024-04-09 12:53 ` [PATCH v6 0/3] " Andy Shevchenko
2024-04-10 2:49 ` albanhuang
2024-04-10 13:40 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhaW3PM3TccV5t3w@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=albanhuang0@gmail.com \
--cc=albanhuang@tencent.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=tombinfan@tencent.com \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).