From: Sudeep Holla <sudeep.holla@arm.com>
To: yunhui cui <cuiyunhui@bytedance.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, bhelgaas@google.com,
james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com,
john.garry@huawei.com, Jonathan.Cameron@huawei.com,
pierre.gondois@arm.com, tiantao6@huawei.com
Subject: Re: [External] Re: [PATCH v2 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT
Date: Mon, 15 Apr 2024 14:21:54 +0100 [thread overview]
Message-ID: <Zh0p8iJe05d71yZK@bogus> (raw)
In-Reply-To: <CAEEQ3wkzvOpahzPuoD7=aMG3srjdyCA21tnh-j9PvY3Qerk_hg@mail.gmail.com>
On Mon, Apr 15, 2024 at 08:03:38PM +0800, yunhui cui wrote:
> Hi Sudeep,
>
> On Mon, Apr 15, 2024 at 4:45 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > On Sun, Apr 14, 2024 at 10:58:25AM +0800, Yunhui Cui wrote:
> > > Before cacheinfo can be built correctly, we need to initialize level
> > > and type. Since RSIC-V currently does not have a register group that
> > > describes cache-related attributes like ARM64, we cannot obtain them
> > > directly, so now we obtain cache leaves from the ACPI PPTT table
> > > (acpi_get_cache_info()) and set the cache type through split_levels.
> > >
> > > Suggested-by: Jeremy Linton <jeremy.linton@arm.com>
> > > Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
> > > Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
> > > ---
> > > arch/riscv/kernel/cacheinfo.c | 23 +++++++++++++++++++++++
> > > 1 file changed, 23 insertions(+)
> > >
> > > diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
> > > index 30a6878287ad..ece92aa404e3 100644
> > > --- a/arch/riscv/kernel/cacheinfo.c
> > > +++ b/arch/riscv/kernel/cacheinfo.c
> > > @@ -6,6 +6,7 @@
> > > #include <linux/cpu.h>
> > > #include <linux/of.h>
> > > #include <asm/cacheinfo.h>
> > > +#include <linux/acpi.h>
> > >
> > > static struct riscv_cacheinfo_ops *rv_cache_ops;
> > >
> > > @@ -78,6 +79,28 @@ int populate_cache_leaves(unsigned int cpu)
> > > struct device_node *prev = NULL;
> > > int levels = 1, level = 1;
> > >
> > > + if (!acpi_disabled) {
> > > + int ret, idx, fw_levels, split_levels;
> > > +
> > > + ret = acpi_get_cache_info(cpu, &fw_levels, &split_levels);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + /* must be set, so we can drop num_leaves assignment below */
> >
> > I intentionally added this above comment to check and drop the below statement
> > if it is already set. Please check if the value is already set when we call
> > into this function(which I think is the case).
> >
> > > + this_cpu_ci->num_leaves = fw_levels + split_levels;
>
> Uh,got it. I understand that there is no need to add this line:
> "this_cpu_ci->num_leaves = fw_levels + split_levels; " , because in
> the Master core first it will:
> smp_prepare_cpus
> ->init_cpu_topology
> ->for_each_possible_cpu(cpu) {
> fetch_cache_info(cpu); //num_leaves and num_levels will be set
> Then store_cpu_topology->update_siblings_masks->detect_cache_attributes->populate_cache_leaves().
>
> Slave core will follow the logic of smp_callin->store_cpu_topology().
> It's the same after I tested it, so I plan to remove that line and
> update V3, what do you think?
>
Correct, just drop the statement updating "this_cpu_ci->num_leaves".
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-04-15 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 2:58 [PATCH v2 1/3] riscv: cacheinfo: remove the useless parameter (node) of ci_leaf_init() Yunhui Cui
2024-04-14 2:58 ` [PATCH v2 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT Yunhui Cui
2024-04-15 8:44 ` Sudeep Holla
2024-04-15 12:03 ` [External] " yunhui cui
2024-04-15 13:21 ` Sudeep Holla [this message]
2024-04-14 2:58 ` [PATCH v2 3/3] RISC-V: Select ACPI PPTT drivers Yunhui Cui
2024-04-15 8:47 ` [PATCH v2 1/3] riscv: cacheinfo: remove the useless parameter (node) of ci_leaf_init() Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh0p8iJe05d71yZK@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=cuiyunhui@bytedance.com \
--cc=james.morse@arm.com \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).