From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Mark Pearson <mpearson@lenovo.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1] ACPI: PM: s2idle: Evaluate all Low-Power S0 Idle _DSM functions
Date: Tue, 23 Apr 2024 21:47:23 +0200 [thread overview]
Message-ID: <CAJZ5v0iKuemDmHCfL67cFyv6gA7Q8cfiNj+nXWqJt2_b_vrhkA@mail.gmail.com> (raw)
In-Reply-To: <08742373-ca86-47e5-ab6c-e2e3189eb9fe@amd.com>
On Tue, Apr 23, 2024 at 9:40 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 4/23/2024 14:19, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Commit 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT
> > UUID for non-AMD systems") attempted to avoid evaluating the same Low-
> > Power S0 Idle _DSM functions for different UUIDs, but that turns out to
> > be a mistake, because some systems in the field are adversely affected
> > by it.
> >
> > Address this by allowing all Low-Power S0 Idle _DSM functions to be
> > evaluated, but still print the message regarding duplication of Low-
> > Power S0 Idle _DSM function sets for different UUIDs.
> >
> > Fixes: 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT UUID for non-AMD systems")
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218750
> > Reported-and-tested-by: Mark Pearson <mpearson@lenovo.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Ah glad to hear that my idea worked.
We've arrived at the same solution independently, I've only looked at
the BZ when the patch was ready to send.
> FWIW we saw the same type of issue
> on some AMD systems when we first introduced the MSFT UUID.
>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
But sure.
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks!
> > ---
> > drivers/acpi/x86/s2idle.c | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > Index: linux-pm/drivers/acpi/x86/s2idle.c
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/x86/s2idle.c
> > +++ linux-pm/drivers/acpi/x86/s2idle.c
> > @@ -492,16 +492,14 @@ static int lps0_device_attach(struct acp
> > unsigned int func_mask;
> >
> > /*
> > - * Avoid evaluating the same _DSM function for two
> > - * different UUIDs and prioritize the MSFT one.
> > + * Log a message if the _DSM function sets for two
> > + * different UUIDs overlap.
> > */
> > func_mask = lps0_dsm_func_mask & lps0_dsm_func_mask_microsoft;
> > - if (func_mask) {
> > + if (func_mask)
> > acpi_handle_info(adev->handle,
> > "Duplicate LPS0 _DSM functions (mask: 0x%x)\n",
> > func_mask);
> > - lps0_dsm_func_mask &= ~func_mask;
> > - }
> > }
> > }
> >
> >
> >
> >
>
prev parent reply other threads:[~2024-04-23 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 19:19 [PATCH v1] ACPI: PM: s2idle: Evaluate all Low-Power S0 Idle _DSM functions Rafael J. Wysocki
2024-04-23 19:40 ` Mario Limonciello
2024-04-23 19:47 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iKuemDmHCfL67cFyv6gA7Q8cfiNj+nXWqJt2_b_vrhkA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mpearson@lenovo.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).