* [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push()
@ 2023-05-29 6:22 Christophe JAILLET
2023-05-29 14:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-05-29 6:22 UTC (permalink / raw
To: Robert Moore, Rafael J. Wysocki, Len Brown
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-acpi,
acpica-devel
'object' is known to be NULL at this point. There is little value to log
it twice in the error message.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/acpi/acpica/dswstate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/dswstate.c b/drivers/acpi/acpica/dswstate.c
index d3841ded3a81..75338a13c802 100644
--- a/drivers/acpi/acpica/dswstate.c
+++ b/drivers/acpi/acpica/dswstate.c
@@ -146,8 +146,8 @@ acpi_ds_result_push(union acpi_operand_object *object,
if (!object) {
ACPI_ERROR((AE_INFO,
- "Null Object! Obj=%p State=%p Num=%u",
- object, walk_state, walk_state->result_count));
+ "Null Object! State=%p Num=%u",
+ walk_state, walk_state->result_count));
return (AE_BAD_PARAMETER);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push()
2023-05-29 6:22 [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push() Christophe JAILLET
@ 2023-05-29 14:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-05-29 14:13 UTC (permalink / raw
To: Christophe JAILLET
Cc: Robert Moore, Rafael J. Wysocki, Len Brown, linux-kernel,
kernel-janitors, linux-acpi, acpica-devel
On Mon, May 29, 2023 at 8:31 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'object' is known to be NULL at this point. There is little value to log
> it twice in the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
ACPICA changes require (at least) a pull request submitted to the
upstream ACPICA project on GitHub.
If you have submitted one, please resend the Linux patch with a Link
tag pointing to the corresponding upstream ACPICA pull request.
Thanks!
> ---
> drivers/acpi/acpica/dswstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/dswstate.c b/drivers/acpi/acpica/dswstate.c
> index d3841ded3a81..75338a13c802 100644
> --- a/drivers/acpi/acpica/dswstate.c
> +++ b/drivers/acpi/acpica/dswstate.c
> @@ -146,8 +146,8 @@ acpi_ds_result_push(union acpi_operand_object *object,
>
> if (!object) {
> ACPI_ERROR((AE_INFO,
> - "Null Object! Obj=%p State=%p Num=%u",
> - object, walk_state, walk_state->result_count));
> + "Null Object! State=%p Num=%u",
> + walk_state, walk_state->result_count));
> return (AE_BAD_PARAMETER);
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-29 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-29 6:22 [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push() Christophe JAILLET
2023-05-29 14:13 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).