From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Jarred White <jarredwhite@linux.microsoft.com>,
Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ACPI: CPPC: Fix access width used for PCC registers
Date: Mon, 8 Apr 2024 22:28:34 -0700 [thread overview]
Message-ID: <694fdd96-cc6e-4a4e-aff5-3284cd3ada4e@linux.microsoft.com> (raw)
In-Reply-To: <365b430b-d91c-4391-bfc4-ea6a3444cb43@linux.microsoft.com>
On 4/8/2024 1:19 PM, Jarred White wrote:
> On 4/1/2024 10:45 AM, Vanshidhar Konda wrote:
>> On Mon, Apr 01, 2024 at 09:48:28AM -0700, Easwar Hariharan wrote:
>>> Hi Vanshi,
>>>
>>> Thanks for testing and catching this. One comment below, but Jarred is OOF for a couple days so
>>> we'll get back again after testing on our platform.
>>>
>>> On 3/29/2024 3:00 PM, Vanshidhar Konda wrote:
>>>> Commit 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
>>>> system memory accesses") modified cpc_read/cpc_write to use access_width to
>>>> read CPC registers. For PCC registers the access width field in the ACPI
>>>> register macro specifies the PCC subspace id. For non-zero PCC subspace id
>>>> the access width is incorrectly treated as access width. This causes errors
>>>> when reading from PCC registers in the CPPC driver.
>>>>
>>>> For PCC registers base the size of read/write on the bit width field.
>>>> The debug message in cpc_read/cpc_write is updated to print relevant
>>>> information for the address space type used to read the register.
>>>>
>>>> Fixes: 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for system memory accesses")
>>>> Signed-off-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
>>>> ---
Hi Vanshi,
When you send v2 for the SystemMemory space fixes, could you add CC: stable@vger.kernel.org # 5.15+
to your commit message, since your patch fixes 2f4a4d63a193 that was marked for stable?
Thanks,
Easwar
prev parent reply other threads:[~2024-04-09 5:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 22:00 [PATCH v1 1/1] ACPI: CPPC: Fix access width used for PCC registers Vanshidhar Konda
2024-04-01 16:48 ` Easwar Hariharan
2024-04-01 17:45 ` Vanshidhar Konda
2024-04-08 20:19 ` Jarred White
2024-04-09 5:28 ` Easwar Hariharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694fdd96-cc6e-4a4e-aff5-3284cd3ada4e@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=jarredwhite@linux.microsoft.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vanshikonda@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).