From: Bjorn Helgaas <helgaas@kernel.org>
To: "Chen, Jiqian" <Jiqian.Chen@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Len Brown" <lenb@kernel.org>, "Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Hildebrand, Stewart" <Stewart.Hildebrand@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: Re: [RFC KERNEL PATCH v4 3/3] PCI/sysfs: Add gsi sysfs for pci_dev
Date: Tue, 9 Apr 2024 15:03:14 -0500 [thread overview]
Message-ID: <20240409200314.GA2086199@bhelgaas> (raw)
In-Reply-To: <BL1PR12MB5849572DFC67B1F8A68E123DE7002@BL1PR12MB5849.namprd12.prod.outlook.com>
[+to Rafael]
On Mon, Apr 08, 2024 at 06:42:31AM +0000, Chen, Jiqian wrote:
> Hi Bjorn,
> It has been almost two months since we received your reply last time.
> This series are blocking on this patch, since there are patches on Xen and Qemu side depending on it.
> Do you still have any confusion about this patch? Or do you have other suggestions?
> If no, may I get your Reviewed-by?
- This is ACPI-specific, but exposes /sys/.../gsi for all systems,
including non-ACPI systems. I don't think we want that.
- Do you care about similar Xen configurations on non-ACPI systems?
If so, maybe the commit log could mention how you learn about PCI
INTx routing on them in case there's some way to unify this in the
future.
- Missing an update to Documentation/ABI/.
- A nit: I asked about s/dumU/DomU/ in the commit log earlier,
haven't seen any response.
- Commit log mentions "and for other potential scenarios." It's
another nit, but unless you have another concrete use for this,
that phrase is meaningless hand waving and should be dropped.
- A _PRT entry may refer directly to a GSI or to an interrupt link
device (PNP0C0F) that can be routed to one of several GSIs:
ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 6 7 9 10 *11 12 14 15)
I don't think the kernel reconfigures interrupt links after
enumeration, but if they are reconfigured at run-time (via _SRS),
the cached GSI will be wrong. I think setpnp could do this, but
that tool is dead. So maybe this isn't a concern anymore, but I
*would* like to get Rafael's take on this. If we don't care
enough, I think we should mention it in the commit log just in
case.
Bjorn
prev parent reply other threads:[~2024-04-09 20:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 6:22 [RFC KERNEL PATCH v4 0/3] Support device passthrough when dom0 is PVH on Xen Jiqian Chen
2024-01-05 6:22 ` [RFC KERNEL PATCH v4 1/3] xen/pci: Add xen_reset_device_state function Jiqian Chen
2024-02-23 0:18 ` Stefano Stabellini
2024-01-05 6:22 ` [RFC KERNEL PATCH v4 2/3] xen/pvh: Setup gsi for passthrough device Jiqian Chen
2024-02-23 0:23 ` Stefano Stabellini
2024-02-23 6:08 ` Chen, Jiqian
2024-01-05 6:22 ` [RFC KERNEL PATCH v4 3/3] PCI/sysfs: Add gsi sysfs for pci_dev Jiqian Chen
2024-01-22 6:36 ` Chen, Jiqian
2024-01-22 23:37 ` Bjorn Helgaas
2024-01-23 10:13 ` Chen, Jiqian
2024-01-23 16:02 ` Bjorn Helgaas
2024-01-25 7:17 ` Chen, Jiqian
2024-01-29 22:01 ` Bjorn Helgaas
2024-01-30 9:07 ` Roger Pau Monné
2024-01-30 20:44 ` Bjorn Helgaas
2024-01-31 8:58 ` Roger Pau Monné
2024-01-31 19:00 ` Bjorn Helgaas
2024-02-01 8:39 ` Roger Pau Monné
2024-02-09 21:05 ` Bjorn Helgaas
2024-02-12 9:13 ` Roger Pau Monné
2024-02-12 19:18 ` Bjorn Helgaas
2024-02-15 8:37 ` Roger Pau Monné
2024-03-01 7:57 ` Chen, Jiqian
2024-04-08 6:42 ` Chen, Jiqian
2024-04-09 20:03 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409200314.GA2086199@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jiqian.Chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Stewart.Hildebrand@amd.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=rafael@kernel.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).