From: Colton Lewis <coltonlewis@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvm@vger.kernel.org, maz@kernel.org, james.morse@arm.com,
suzuki.poulose@arm.com, yuzenghui@huawei.com,
ricarkol@google.com, kvmarm@lists.linux.dev
Subject: Re: [PATCH v4 2/3] KVM: arm64: selftests: Guarantee interrupts are handled
Date: Mon, 11 Mar 2024 17:48:37 +0000 [thread overview]
Message-ID: <gsntzfv4slqi.fsf@coltonlewis-kvm.c.googlers.com> (raw)
In-Reply-To: <Ze6PMRMfIK8z0q4F@thinky-boi> (message from Oliver Upton on Sun, 10 Mar 2024 21:57:21 -0700)
Oliver Upton <oliver.upton@linux.dev> writes:
>> - asm volatile("wfi\n"
>> - "msr daifclr, #2\n"
>> - /* handle IRQ */
>> - "msr daifset, #2\n"
>> - : : : "memory");
>> + gic_wfi();
>> + local_irq_enable();
>> + isb();
>> + /* handle IRQ */
>> + local_irq_disable();
> Sorry, this *still* annoys me. Please move the comment above the ISB,
> you're documenting a behavior that is implied by the instruction, not
> anything else.
Fixing this too. I changed this in the third patch but forgot there
was also an instance in the second.
next prev parent reply other threads:[~2024-03-11 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:39 [PATCH v4 0/3] Add arch_timer_edge_cases selftest Colton Lewis
2024-03-07 18:39 ` [PATCH v4 1/3] KVM: arm64: selftests: Standardize GIC base addresses Colton Lewis
2024-03-07 18:39 ` [PATCH v4 2/3] KVM: arm64: selftests: Guarantee interrupts are handled Colton Lewis
2024-03-11 4:57 ` Oliver Upton
2024-03-11 17:14 ` Colton Lewis
2024-03-11 17:48 ` Colton Lewis [this message]
2024-03-07 18:39 ` [PATCH v4 3/3] KVM: arm64: selftests: Add arch_timer_edge_cases selftest Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gsntzfv4slqi.fsf@coltonlewis-kvm.c.googlers.com \
--to=coltonlewis@google.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=ricarkol@google.com \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).