From: Zenghui Yu <yuzenghui@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Wujie Duan <wjduan@linx-info.com>,
Ard Biesheuvel <ardb@kernel.org>, <oliver.upton@linux.dev>,
<james.morse@arm.com>, <suzuki.poulose@arm.com>,
<kvmarm@lists.linux.dev>
Subject: Re: [PATCH] Change back kvm fault condition to translation
Date: Mon, 18 Mar 2024 17:33:50 +0800 [thread overview]
Message-ID: <ec589d2d-db95-3e98-6c35-0c4a2232013d@huawei.com> (raw)
In-Reply-To: <865xxj29n8.wl-maz@kernel.org>
On 2024/3/18 17:04, Marc Zyngier wrote:
> [+Ard]
>
> On Mon, 18 Mar 2024 05:37:08 +0000,
> Wujie Duan <wjduan@linx-info.com> wrote:
>>
>> Condition should be esr_fsc_is_translation_fault
>
> Could you please write a full commit message, and not something that
> requires the reviewer to reverse-engineer the issue? Description of
> the problem, the commit it fixes, a Cc stable tag, this sort of
> things.
And also Cc the kvmarm list, a proper patch subject (starting with
"KVM: arm64:").
> Otherwise, this looks embarrassingly correct. Ard?
I tend to agree. ;-)
Zenghui
next parent reply other threads:[~2024-03-18 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240318053708.192770-1-wjduan@linx-info.com>
[not found] ` <865xxj29n8.wl-maz@kernel.org>
2024-03-18 9:33 ` Zenghui Yu [this message]
2024-03-18 9:47 [PATCH] Change back kvm fault condition to translation Wujie Duan
-- strict thread matches above, loose matches on Subject: below --
2024-03-18 10:00 Wujie Duan
2024-03-18 10:01 Wujie Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec589d2d-db95-3e98-6c35-0c4a2232013d@huawei.com \
--to=yuzenghui@huawei.com \
--cc=ardb@kernel.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=wjduan@linx-info.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).