KVM ARM Archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Pavel Machek <pavel@denx.de>
Cc: Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Oliver Upton <oliver.upton@linux.dev>,
	pbonzini@redhat.com, shuah@kernel.org,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF
Date: Mon, 13 May 2024 09:27:57 +0100	[thread overview]
Message-ID: <86zfsum7zm.wl-maz@kernel.org> (raw)
In-Reply-To: <ZkHNVtwcrf91k+dR@duo.ucw.cz>

On Mon, 13 May 2024 09:20:38 +0100,
Pavel Machek <pavel@denx.de> wrote:
> 
> Hi!
> 
> > Assert that accesses to a non-existent vgic-v2 CPU interface
> > consistently fail across the various KVM device attr ioctls. This also
> > serves as a regression test for a bug wherein KVM hits a NULL
> > dereference when the CPUID specified in the ioctl is invalid.
> > 
> > Note that there is no need to print the observed errno, as TEST_ASSERT()
> > will take care of it.
> 
> I don't think this fixes the bug... and thus we should not need it in
> stable.

Given that this goes together with an actually bug fix that was
backported, it *is*, for once, actually useful to have it in stable.

	M.

-- 
Without deviation from the norm, progress is not possible.

      reply	other threads:[~2024-05-13  8:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240507231231.394219-1-sashal@kernel.org>
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF Sasha Levin
2024-05-13  8:20   ` Pavel Machek
2024-05-13  8:27     ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfsum7zm.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pavel@denx.de \
    --cc=pbonzini@redhat.com \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).