From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
kvm@vger.kernel.org, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH 2/2] arm64: cpufeatures: Only check for NV1 if NV is present
Date: Thu, 15 Feb 2024 15:19:02 +0000 [thread overview]
Message-ID: <86le7l4uxl.wl-maz@kernel.org> (raw)
In-Reply-To: <Zc1wsKzAvooOvR-v@linux.dev>
On Thu, 15 Feb 2024 02:02:24 +0000,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> On Tue, Feb 13, 2024 at 02:21:48PM +0000, Marc Zyngier wrote:
> > From cd75279d3b6c387c13972b61c486a203d9652e97 Mon Sep 17 00:00:00 2001
> > From: Marc Zyngier <maz@kernel.org>
> > Date: Tue, 13 Feb 2024 13:37:57 +0000
> > Subject: [PATCH] arm64: cpufeatures: Fix FEAT_NV check when checking for
> > FEAT_NV1
> >
> > Using this_cpu_has_cap() has the potential to go wrong when
> > used system-wide on a preemptible kernel. Instead, use the
> > __system_matches_cap() helper when checking for FEAT_NV in the
> > FEAT_NV1 probing helper.
> >
> > Fixes: 3673d01a2f55 ("arm64: cpufeatures: Only check for NV1 if NV is present")
> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> b4 wasn't very happy with grabbing this patch in reply to a series
> (probably user error), but I've picked this up for kvmarm/next.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/commit/?id=9aa030cee1c45d6e962f6bf22ba63d4aff2b1644
Ah, sorry, I should have posted as a proper patch instead of an inline
patch. Thanks for picking it up despite that.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-02-15 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 14:47 [PATCH 0/2] ARM64: Fixes for FEAT_E2H0 handling Marc Zyngier
2024-02-12 14:47 ` [PATCH 1/2] arm64: cpufeatures: Add missing ID_AA64MMFR4_EL1 to __read_sysreg_by_encoding() Marc Zyngier
2024-02-12 14:47 ` [PATCH 2/2] arm64: cpufeatures: Only check for NV1 if NV is present Marc Zyngier
2024-02-13 11:14 ` Marek Szyprowski
2024-02-13 14:21 ` Marc Zyngier
2024-02-13 14:54 ` Suzuki K Poulose
2024-02-13 20:06 ` Marek Szyprowski
2024-02-15 2:02 ` Oliver Upton
2024-02-15 15:19 ` Marc Zyngier [this message]
2024-02-12 18:05 ` [PATCH 0/2] ARM64: Fixes for FEAT_E2H0 handling Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le7l4uxl.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).