From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Vineeth Pillai <viremana@linux.microsoft.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"K. Y. Srinivasan" <kys@microsoft.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
Lan Tianyu <Tianyu.Lan@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
Sean Christopherson <seanjc@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Wei Liu <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH v5 7/7] KVM: SVM: hyper-v: Direct Virtual Flush support
Date: Thu, 10 Jun 2021 17:16:55 +0200 [thread overview]
Message-ID: <dacd2187-2952-afa7-3802-9a7b9b99856d@redhat.com> (raw)
In-Reply-To: <871r9aynoe.fsf@vitty.brq.redhat.com>
On 10/06/21 13:16, Vitaly Kuznetsov wrote:
>> +int hv_enable_direct_tlbflush(struct kvm_vcpu *vcpu)
>> +{
> I would've avoided re-using 'hv_enable_direct_tlbflush()' name which we
> already have in vmx. In fact, in the spirit of this patch, I'd suggest
> we create arch/x86/kvm/vmx/vmx_onhyperv.c and move the existing
> hv_enable_direct_tlbflush() there. We can then re-name it to e.g.
>
> vmx_enable_hv_direct_tlbflush()
>
> so the one introduced by this patch will be
>
> svm_enable_hv_direct_tlbflush()
>
I did the rename, and agree with creating a similar file that is split
off vmx.c.
Paolo
next prev parent reply other threads:[~2021-06-10 15:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 15:14 [PATCH v5 0/7] Hyper-V nested virt enlightenments for SVM Vineeth Pillai
2021-06-03 15:14 ` [PATCH v5 1/7] hyperv: Detect Nested virtualization support " Vineeth Pillai
2021-06-08 16:59 ` Michael Kelley
2021-06-03 15:14 ` [PATCH v5 2/7] hyperv: SVM enlightened TLB flush support flag Vineeth Pillai
2021-06-08 17:04 ` Michael Kelley
2021-06-03 15:14 ` [PATCH v5 3/7] KVM: x86: hyper-v: Move the remote TLB flush logic out of vmx Vineeth Pillai
2021-06-10 11:20 ` Vitaly Kuznetsov
2021-06-10 15:11 ` Paolo Bonzini
2021-06-11 7:20 ` Vitaly Kuznetsov
2021-06-03 15:14 ` [PATCH v5 4/7] KVM: SVM: Software reserved fields Vineeth Pillai
2021-06-03 15:14 ` [PATCH v5 5/7] KVM: SVM: hyper-v: Remote TLB flush for SVM Vineeth Pillai
2021-06-08 17:33 ` Michael Kelley
2021-06-03 15:14 ` [PATCH v5 6/7] KVM: SVM: hyper-v: Enlightened MSR-Bitmap support Vineeth Pillai
2021-06-03 15:14 ` [PATCH v5 7/7] KVM: SVM: hyper-v: Direct Virtual Flush support Vineeth Pillai
2021-06-10 11:16 ` Vitaly Kuznetsov
2021-06-10 15:16 ` Paolo Bonzini [this message]
2021-06-14 11:34 ` Vitaly Kuznetsov
2021-06-15 14:24 ` Vineeth Pillai
2021-06-10 15:17 ` [PATCH v5 0/7] Hyper-V nested virt enlightenments for SVM Paolo Bonzini
2021-06-11 9:26 ` Maxim Levitsky
2021-06-11 9:44 ` Vitaly Kuznetsov
2021-06-11 16:50 ` Paolo Bonzini
2021-06-14 7:47 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dacd2187-2952-afa7-3802-9a7b9b99856d@redhat.com \
--to=pbonzini@redhat.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=viremana@linux.microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).