From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Edward Liaw" <edliaw@google.com>, <shuah@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Sean Christopherson" <seanjc@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bongsu Jeon" <bongsu.jeon@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Muhammad Usama Anjum" <usama.anjum@collabora.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<kernel-team@android.com>, <linux-sound@vger.kernel.org>,
<linux-input@vger.kernel.org>, <kvm@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-rtc@vger.kernel.org>,
<linux-sgx@vger.kernel.org>,
"kernel test robot" <oliver.sang@intel.com>
Subject: Re: [PATCH v1 01/10] selftests/sgx: Compile with -D_GNU_SOURCE
Date: Fri, 03 May 2024 04:46:43 +0300 [thread overview]
Message-ID: <D0ZMPEICUP93.YHFFOSJBS27X@kernel.org> (raw)
In-Reply-To: <20240430235057.1351993-2-edliaw@google.com>
On Wed May 1, 2024 at 2:50 AM EEST, Edward Liaw wrote:
> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced
> asprintf into kselftest_harness.h, which is a GNU extension and needs
> _GNU_SOURCE to either be defined prior to including headers or with the
> -D_GNU_SOURCE flag passed to the compiler.
>
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
> tools/testing/selftests/sgx/Makefile | 2 +-
> tools/testing/selftests/sgx/sigstruct.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile
> index 867f88ce2570..272da790d9ae 100644
> --- a/tools/testing/selftests/sgx/Makefile
> +++ b/tools/testing/selftests/sgx/Makefile
> @@ -12,7 +12,7 @@ OBJCOPY := $(CROSS_COMPILE)objcopy
> endif
>
> INCLUDES := -I$(top_srcdir)/tools/include
> -HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
> +HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC -D_GNU_SOURCE
> HOST_LDFLAGS := -z noexecstack -lcrypto
> ENCL_CFLAGS += -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE \
> -fno-stack-protector -mrdrnd $(INCLUDES)
> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
> index d73b29becf5b..a0c2de7c5302 100644
> --- a/tools/testing/selftests/sgx/sigstruct.c
> +++ b/tools/testing/selftests/sgx/sigstruct.c
> @@ -1,7 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> /* Copyright(c) 2016-20 Intel Corporation. */
> -
> -#define _GNU_SOURCE
> #include <assert.h>
> #include <getopt.h>
> #include <stdbool.h>
> --
> 2.45.0.rc0.197.gbae5840b3b-goog
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2024-05-03 1:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 23:50 [PATCH v1 00/10] Define _GNU_SOURCE for sources using Edward Liaw
2024-04-30 23:50 ` [PATCH v1 01/10] selftests/sgx: Compile with -D_GNU_SOURCE Edward Liaw
2024-05-03 1:46 ` Jarkko Sakkinen [this message]
2024-04-30 23:50 ` [PATCH v1 02/10] selftests/alsa: " Edward Liaw
2024-04-30 23:50 ` [PATCH v1 03/10] selftests/hid: " Edward Liaw
2024-04-30 23:50 ` [PATCH v1 04/10] selftests/kvm: Define _GNU_SOURCE Edward Liaw
2024-05-01 13:26 ` Sean Christopherson
2024-04-30 23:50 ` [PATCH v1 05/10] selftests/nci: Compile with -D_GNU_SOURCE Edward Liaw
2024-04-30 23:50 ` [PATCH v1 06/10] selftests/net: Define _GNU_SOURCE Edward Liaw
2024-04-30 23:50 ` [PATCH v1 07/10] selftests/prctl: Compile with -D_GNU_SOURCE Edward Liaw
2024-04-30 23:50 ` [PATCH v1 08/10] selftests/rtc: " Edward Liaw
2024-04-30 23:50 ` [PATCH v1 09/10] selftests/tdx: " Edward Liaw
2024-04-30 23:50 ` [PATCH v1 10/10] selftests/user_events: Compiled " Edward Liaw
2024-05-01 1:59 ` [PATCH v1 00/10] Define _GNU_SOURCE for sources using Mark Brown
2024-05-01 5:40 ` Muhammad Usama Anjum
2024-05-07 17:53 ` Edward Liaw
2024-05-01 13:24 ` Sean Christopherson
2024-05-02 22:41 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0ZMPEICUP93.YHFFOSJBS27X@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=bentiss@kernel.org \
--cc=bongsu.jeon@samsung.com \
--cc=broonie@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edliaw@google.com \
--cc=edumazet@google.com \
--cc=jikos@kernel.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).