From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Yi Wang <up2wing@gmail.com>,
seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, wanpengli@tencent.com,
foxywang@tencent.com, oliver.upton@linux.dev, maz@kernel.org,
anup@brainfault.org, atishp@atishpatra.org,
frankja@linux.ibm.com, imbrenda@linux.ibm.com,
weijiang.yang@intel.com
Subject: Re: [v5 3/3] KVM: s390: don't setup dummy routing when KVM_CREATE_IRQCHIP
Date: Mon, 6 May 2024 13:42:11 +0200 [thread overview]
Message-ID: <5f586a9e-2982-497a-8674-cd788f2e8308@linux.ibm.com> (raw)
In-Reply-To: <20240506101751.3145407-4-foxywang@tencent.com>
Am 06.05.24 um 12:17 schrieb Yi Wang:
> From: Yi Wang <foxywang@tencent.com>
>
> As we have setup empty irq routing in kvm_create_vm(), there's
> no need to setup dummy routing when KVM_CREATE_IRQCHIP.
>
> Signed-off-by: Yi Wang <foxywang@tencent.com>
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 5147b943a864..ba7fd39bcbf4 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -2998,14 +2998,7 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
> break;
> }
> case KVM_CREATE_IRQCHIP: {
> - struct kvm_irq_routing_entry routing;
> -
> - r = -EINVAL;
> - if (kvm->arch.use_irqchip) {
> - /* Set up dummy routing. */
> - memset(&routing, 0, sizeof(routing));
> - r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> - }
> + r = 0;
> break;
> }
> case KVM_SET_DEVICE_ATTR: {
prev parent reply other threads:[~2024-05-06 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:17 [v5 0/3] KVM: irqchip: synchronize srcu only if needed Yi Wang
2024-05-06 10:17 ` [v5 1/3] KVM: setup empty irq routing when create vm Yi Wang
2024-05-06 11:41 ` Christian Borntraeger
2024-05-06 10:17 ` [v5 2/3] KVM: x86: don't setup empty irq routing when KVM_CAP_SPLIT_IRQCHIP Yi Wang
2024-05-06 10:17 ` [v5 3/3] KVM: s390: don't setup dummy routing when KVM_CREATE_IRQCHIP Yi Wang
2024-05-06 11:42 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f586a9e-2982-497a-8674-cd788f2e8308@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=foxywang@tencent.com \
--cc=frankja@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=up2wing@gmail.com \
--cc=wanpengli@tencent.com \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).