From: Shaoqin Huang <shahuang@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-arm@nongnu.org, Eric Auger <eauger@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER
Date: Tue, 7 May 2024 17:33:27 +0800 [thread overview]
Message-ID: <2df3915c-8928-4c01-979e-8c71603a2279@redhat.com> (raw)
In-Reply-To: <Zh1j9b92UGPzr1-a@redhat.com>
Hi Daniel,
On 4/16/24 01:29, Daniel P. Berrangé wrote:
> On Mon, Apr 08, 2024 at 10:49:40PM -0400, Shaoqin Huang wrote:
>> The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
>> which PMU events are provided to the guest. Add a new option
>> `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering.
>> Without the filter, all PMU events are exposed from host to guest by
>> default. The usage of the new sub-option can be found from the updated
>> document (docs/system/arm/cpu-features.rst).
>>
>> Here is an example which shows how to use the PMU Event Filtering, when
>> we launch a guest by use kvm, add such command line:
>>
>> # qemu-system-aarch64 \
>> -accel kvm \
>> -cpu host,kvm-pmu-filter="D:0x11-0x11"
>
> I'm still against implementing this one-off custom parsed syntax
> for kvm-pmu-filter values. Once this syntax exists, we're locked
> into back-compatibility for multiple releases, and it will make
> a conversion to QAPI/JSON harder.
Thanks for your effort of reviewing my patch. I think if I need cost
more time about the QAPI, that's outside my initial idea and deviate
from supporting the PMU Filter.
So I decide to not update this patch now. And wait until I have time to
look into the QAPI or the -cpu option has been transformed to QAPI format.
Thanks,
Shaoqin
>
> With regards,
> Daniel
--
Shaoqin
next prev parent reply other threads:[~2024-05-07 9:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 2:49 [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER Shaoqin Huang
2024-04-09 5:33 ` Thomas Huth
2024-04-09 7:47 ` Shaoqin Huang
2024-04-10 6:07 ` Thomas Huth
2024-04-16 15:17 ` Cornelia Huck
2024-04-15 17:29 ` Daniel P. Berrangé
2024-05-07 9:33 ` Shaoqin Huang [this message]
2024-05-09 9:48 ` Zhao Liu
2024-05-09 9:39 ` Daniel P. Berrangé
2024-05-13 6:52 ` Zhao Liu
2024-05-15 16:47 ` Daniel P. Berrangé
2024-05-27 6:41 ` Shaoqin Huang
2024-05-27 10:24 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df3915c-8928-4c01-979e-8c71603a2279@redhat.com \
--to=shahuang@redhat.com \
--cc=berrange@redhat.com \
--cc=eauger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).