From: "Aithal, Srikanth" <sraithal@amd.com>
To: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
Ashish Kalra <ashish.kalra@amd.com>,
Joerg Roedel <joro@8bytes.org>,
Michael Roth <michael.roth@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 0/5] x86/sev: Fix SNP host late disable
Date: Wed, 3 Apr 2024 09:45:43 +0530 [thread overview]
Message-ID: <29030dd5-ccd8-48cf-a25a-e98966bf57bb@amd.com> (raw)
In-Reply-To: <20240327154317.29909-1-bp@alien8.de>
On 3/27/2024 9:13 PM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> Hi,
>
> the intention to track SNP host status with the CPU feature bit
> X86_FEATURE_SEV_SNP was all fine and dandy but that can't work if stuff
> needs to be disabled late, after alternatives patching - see patch 5.
>
> Therefore, convert the SNP status tracking to a cc_platform*() bit.
>
> The first two are long overdue cleanups.
>
> If no objections, 3-5 should go in now so that 6.9 releases fixed.
>
> Thx.
>
> Borislav Petkov (AMD) (5):
> x86/alternatives: Remove a superfluous newline in _static_cpu_has()
> x86/alternatives: Catch late X86_FEATURE modifiers
> x86/kvm/Kconfig: Have KVM_AMD_SEV select ARCH_HAS_CC_PLATFORM
> x86/cc: Add cc_platform_set/_clear() helpers
> x86/CPU/AMD: Track SNP host status with cc_platform_*()
>
> arch/x86/coco/core.c | 52 ++++++++++++++++++++++++++++++
> arch/x86/include/asm/cpufeature.h | 11 ++++---
> arch/x86/include/asm/sev.h | 4 +--
> arch/x86/kernel/cpu/amd.c | 38 +++++++++++++---------
> arch/x86/kernel/cpu/cpuid-deps.c | 3 ++
> arch/x86/kernel/cpu/mtrr/generic.c | 2 +-
> arch/x86/kernel/sev.c | 10 ------
> arch/x86/kvm/Kconfig | 1 +
> arch/x86/kvm/svm/sev.c | 2 +-
> arch/x86/virt/svm/sev.c | 26 ++++++++++-----
> drivers/crypto/ccp/sev-dev.c | 2 +-
> drivers/iommu/amd/init.c | 4 ++-
> include/linux/cc_platform.h | 12 +++++++
> 13 files changed, 124 insertions(+), 43 deletions(-)
>
Tested this patch. I could boot with snp enabled and iommu=pt mode,kexec
as well works fine. Thank you.
Tested-by: Srikanth Aithal <sraithal@amd.com>
prev parent reply other threads:[~2024-04-03 4:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 15:43 [PATCH 0/5] x86/sev: Fix SNP host late disable Borislav Petkov
2024-03-27 15:43 ` [PATCH 1/5] x86/alternatives: Remove a superfluous newline in _static_cpu_has() Borislav Petkov
2024-03-27 15:43 ` [PATCH 2/5] x86/alternatives: Catch late X86_FEATURE modifiers Borislav Petkov
2024-03-27 15:57 ` Nikolay Borisov
2024-04-03 17:59 ` Borislav Petkov
2024-03-27 15:43 ` [PATCH 3/5] x86/kvm/Kconfig: Have KVM_AMD_SEV select ARCH_HAS_CC_PLATFORM Borislav Petkov
2024-03-29 14:42 ` Tom Lendacky
2024-03-27 15:43 ` [PATCH 4/5] x86/cc: Add cc_platform_set/_clear() helpers Borislav Petkov
2024-03-29 14:46 ` Tom Lendacky
2024-03-27 15:43 ` [PATCH 5/5] x86/CPU/AMD: Track SNP host status with cc_platform_*() Borislav Petkov
2024-03-28 11:51 ` Jeremi Piotrowski
2024-03-28 13:41 ` Borislav Petkov
2024-03-28 14:24 ` Jeremi Piotrowski
2024-03-28 15:39 ` Borislav Petkov
2024-04-04 17:07 ` Jeremi Piotrowski
2024-04-24 18:46 ` Borislav Petkov
2024-03-29 14:52 ` Tom Lendacky
2024-04-03 4:15 ` Aithal, Srikanth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29030dd5-ccd8-48cf-a25a-e98966bf57bb@amd.com \
--to=sraithal@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).