KVM Archive mirror
 help / color / mirror / Atom feed
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
To: kvm@vger.kernel.org, seanjc@google.com, vasant.hegde@amd.com
Cc: pbonzini@redhat.com, linux-kernel@vger.kernel.org,
	joao.m.martins@oracle.com, boris.ostrovsky@oracle.com,
	suravee.suthikulpanit@amd.com, mlevitsk@redhat.com,
	alejandro.j.jimenez@oracle.com
Subject: [PATCH v2 0/2] Print names of apicv inhibit reasons in traces
Date: Mon,  6 May 2024 22:53:19 +0000	[thread overview]
Message-ID: <20240506225321.3440701-1-alejandro.j.jimenez@oracle.com> (raw)

v2:
- Use Sean's implementation/patch from v1: https://lore.kernel.org/all/ZjVQOFLXWrZvoa-Y@google.com/
- Fix typo in commit message (s/inhbit/inhibit).
- Add patch renaming APICV_INHIBIT_REASON_DISABLE to APICV_INHIBIT_REASON_DISABLED.
- Drop Vasant's R-b from v1 since implementation was refined, even though the
general approach and behavior remains the same.

v1: https://lore.kernel.org/all/20240214223554.1033154-1-alejandro.j.jimenez@oracle.com/

Tested on Genoa system. With the proposed changes, the tracepoint output looks
like the following examples:

 qemu-system-x86-7068    [194] .....  1397.647770: kvm_apicv_inhibit_changed: set reason=2, inhibits=0x4 ABSENT
 qemu-system-x86-7068    [003] .....  1397.676703: kvm_apicv_inhibit_changed: cleared reason=2, inhibits=0x0
 qemu-system-x86-7074    [247] .....  1397.701398: kvm_apicv_inhibit_changed: cleared reason=4, inhibits=0x0

 qemu-system-x86-7074    [008] .....  1408.697413: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x100 IRQWIN
 qemu-system-x86-7074    [008] .....  1408.697420: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x0

[...]

 qemu-system-x86-7173    [056] .....  1570.541372: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x300 IRQWIN|PIT_REINJ
 qemu-system-x86-7173    [056] .....  1570.541380: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x200 PIT_REINJ


Alejandro Jimenez (2):
  KVM: x86: Print names of apicv inhibit reasons in traces
  KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons

 arch/x86/include/asm/kvm_host.h | 21 ++++++++++++++++++++-
 arch/x86/kvm/svm/svm.h          |  2 +-
 arch/x86/kvm/trace.h            |  9 +++++++--
 arch/x86/kvm/vmx/main.c         |  2 +-
 arch/x86/kvm/x86.c              |  6 +++++-
 5 files changed, 34 insertions(+), 6 deletions(-)


base-commit: d91a9cc16417b8247213a0144a1f0fd61dc855dd
-- 
2.39.3


             reply	other threads:[~2024-05-06 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 22:53 Alejandro Jimenez [this message]
2024-05-06 22:53 ` [PATCH v2 1/2] KVM: x86: Print names of apicv inhibit reasons in traces Alejandro Jimenez
2024-05-08 11:20   ` Vasant Hegde
2024-05-06 22:53 ` [PATCH v2 2/2] KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons Alejandro Jimenez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240506225321.3440701-1-alejandro.j.jimenez@oracle.com \
    --to=alejandro.j.jimenez@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).