From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>, Andrew Jones <andrew.jones@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>, kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH 2/2] shellcheck: Suppress SC2209 quoting warning in config.mak
Date: Fri, 3 May 2024 15:25:07 +1000 [thread overview]
Message-ID: <20240503052510.968229-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240503052510.968229-1-npiggin@gmail.com>
It's not necessary to quote strings in simple command variables like
this where the pattern makes the intention quite clear.
config.mak is also included as Makefile, and in that case the quotes
do slightly change behaviour (the quotes are used when invoking the
command), and is not the typical Makefile style.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
configure | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index a8520a35f..0e0a28825 100755
--- a/configure
+++ b/configure
@@ -420,6 +420,8 @@ ln -sf "$asm" lib/asm
cat <<EOF > config.mak
# Shellcheck does not see these are used
# shellcheck disable=SC2034
+# Shellcheck can give pointless quoting warnings for some commands
+# shellcheck disable=SC2209
SRCDIR=$srcdir
PREFIX=$prefix
HOST=$host
--
2.43.0
next prev parent reply other threads:[~2024-05-03 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 5:25 [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Nicholas Piggin
2024-05-03 5:25 ` [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build Nicholas Piggin
2024-05-03 6:31 ` Thomas Huth
2024-05-03 5:25 ` Nicholas Piggin [this message]
2024-05-03 6:31 ` [kvm-unit-tests PATCH 2/2] shellcheck: Suppress SC2209 quoting warning in config.mak Thomas Huth
2024-05-03 6:35 ` [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503052510.968229-3-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).