From: Andrew Jones <andrew.jones@linux.dev>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Alexandru Elisei <alexandru.elisei@arm.com>,
Eric Auger <eric.auger@redhat.com>,
kvmarm@lists.linux.dev, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] arm64: Default to 4K translation granule
Date: Thu, 2 May 2024 17:29:43 +0200 [thread overview]
Message-ID: <20240502-5c8299c501529abfbbe1abf3@orel> (raw)
In-Reply-To: <20240502074156.1346049-1-oliver.upton@linux.dev>
On Thu, May 02, 2024 at 07:41:56AM GMT, Oliver Upton wrote:
> Some arm64 implementations in the wild, like the Apple parts, do not
> support the 64K translation granule. This can be a bit annoying when
> running with the defaults on such hardware, as every test fails
> before getting the MMU turned on.
>
> Switch the default page size to 4K with the intention of having the
> default setting be the most widely applicable one.
>
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> ---
> configure | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index 49f047cb2d7d..4ac2ff3e6106 100755
> --- a/configure
> +++ b/configure
> @@ -75,7 +75,7 @@ usage() {
> (s390x only)
> --page-size=PAGE_SIZE
> Specify the page size (translation granule) (4k, 16k or
> - 64k, default is 64k, arm64 only)
> + 64k, default is 4k, arm64 only)
> --earlycon=EARLYCON
> Specify the UART name, type and address (optional, arm and
> arm64 only). The specified address will overwrite the UART
> @@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
> fi
>
> if [ -z "$page_size" ]; then
> - if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
> - page_size="4096"
> - elif [ "$arch" = "arm64" ]; then
> - page_size="65536"
> - elif [ "$arch" = "arm" ]; then
> + if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
> page_size="4096"
> fi
> else
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>
Merged.
Thanks,
drew
prev parent reply other threads:[~2024-05-02 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 7:41 [kvm-unit-tests PATCH] arm64: Default to 4K translation granule Oliver Upton
2024-05-02 7:58 ` Thomas Huth
2024-05-02 8:53 ` Alexandru Elisei
2024-05-02 9:05 ` Andrew Jones
2024-05-02 16:08 ` Oliver Upton
2024-05-02 10:10 ` Zenghui Yu
2024-05-02 15:29 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502-5c8299c501529abfbbe1abf3@orel \
--to=andrew.jones@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).