KVM Archive mirror
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: thuth@redhat.com, pbonzini@redhat.com, andrew.jones@linux.dev
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests GIT PULL 02/13] lib: s390x: sigp: Dirty CC before sigp execution
Date: Wed, 24 Apr 2024 12:59:21 +0200	[thread overview]
Message-ID: <20240424105935.184138-3-nrb@linux.ibm.com> (raw)
In-Reply-To: <20240424105935.184138-1-nrb@linux.ibm.com>

From: Janosch Frank <frankja@linux.ibm.com>

Dirtying the CC allows us to find missing CC changes when sigp is
emulated.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Link: https://lore.kernel.org/r/20240131074427.70871-2-frankja@linux.ibm.com
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
 lib/s390x/asm/sigp.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/s390x/asm/sigp.h b/lib/s390x/asm/sigp.h
index 61d2c625..4eae95d0 100644
--- a/lib/s390x/asm/sigp.h
+++ b/lib/s390x/asm/sigp.h
@@ -49,13 +49,17 @@ static inline int sigp(uint16_t addr, uint8_t order, unsigned long parm,
 		       uint32_t *status)
 {
 	register unsigned long reg1 asm ("1") = parm;
+	uint64_t bogus_cc = SIGP_CC_NOT_OPERATIONAL;
 	int cc;
 
 	asm volatile(
+		"	tmll	%[bogus_cc],3\n"
 		"	sigp	%1,%2,0(%3)\n"
 		"	ipm	%0\n"
 		"	srl	%0,28\n"
-		: "=d" (cc), "+d" (reg1) : "d" (addr), "a" (order) : "cc");
+		: "=d" (cc), "+d" (reg1)
+		: "d" (addr), "a" (order), [bogus_cc] "d" (bogus_cc)
+		: "cc");
 	if (status)
 		*status = reg1;
 	return cc;
-- 
2.44.0


  parent reply	other threads:[~2024-04-24 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 10:59 [kvm-unit-tests GIT PULL 00/13] s390x: Improvement of CMM test, lot of small bugfixes and two refactorings Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 01/13] s390x/Makefile: simplify Secure Execution boot image generation Nico Boehr
2024-04-24 10:59 ` Nico Boehr [this message]
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 03/13] lib: s390x: uv: Dirty CC before uvc execution Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 04/13] lib: s390x: css: Dirty CC before css instructions Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 05/13] s390x: mvpg: Dirty CC before mvpg execution Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 06/13] s390x: sclp: Dirty CC before sclp execution Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 07/13] lib: s390x: sigp: Name inline assembly arguments Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 08/13] s390x: add pv-attest to unittests.cfg Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 09/13] s390x: emulator: Fix error path of invalid function code Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 10/13] s390x: Fix is_pv check in run script Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 11/13] s390x: Use local accel variable in arch_cmd_s390x Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 12/13] lib: s390: fix guest length in uv_create_guest() Nico Boehr
2024-04-24 10:59 ` [kvm-unit-tests GIT PULL 13/13] s390x: cmm: test no-translate bit after reset Nico Boehr
2024-04-24 11:32 ` [kvm-unit-tests GIT PULL 00/13] s390x: Improvement of CMM test, lot of small bugfixes and two refactorings Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424105935.184138-3-nrb@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=andrew.jones@linux.dev \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).