From: Alex Williamson <alex.williamson@redhat.com>
To: Nipun Gupta <nipun.gupta@amd.com>
Cc: <tglx@linutronix.de>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
<maz@kernel.org>, <git@amd.com>, <harpreet.anand@amd.com>,
<pieter.jansen-van-vuuren@amd.com>, <nikhil.agarwal@amd.com>,
<michal.simek@amd.com>, <abhijit.gangurde@amd.com>,
<srivatsa@csail.mit.edu>
Subject: Re: [PATCH v6 1/2] genirq/msi: add wrapper msi allocation API and export msi functions
Date: Tue, 23 Apr 2024 15:09:20 -0600 [thread overview]
Message-ID: <20240423150920.12fe4a3e.alex.williamson@redhat.com> (raw)
In-Reply-To: <20240423111021.1686144-1-nipun.gupta@amd.com>
On Tue, 23 Apr 2024 16:40:20 +0530
Nipun Gupta <nipun.gupta@amd.com> wrote:
> SI functions for allocation and free can be directly used by
We lost the ^M in this version.
> the device drivers without any wrapper provided by bus drivers.
> So export these MSI functions.
>
> Also, add a wrapper API to allocate MSIs providing only the
> number of interrupts rather than range for simpler driver usage.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>
> No change in v5->v6
>
> Changes in v4->v5:
> - updated commit description as per the comments.
I see in https://lore.kernel.org/all/87edbyfj0d.ffs@tglx/ that Thomas
also suggested a new subject:
genirq/msi: Add MSI allocation helper and export MSI functions
I'll address both of these on commit if there are no objections or
further comments. Patch 2/ looks ok to me now as well. Thanks,
Alex
> - Rebased on 6.9-rc1
>
> Changes in v3->v4:
> - No change
>
> Changes in v3:
> - New in this patch series. VFIO-CDX uses the new wrapper API
> msi_domain_alloc_irqs and exported APIs. (This patch is moved
> from CDX interrupt support to vfio-cdx patch, where these APIs
> are used).
>
> include/linux/msi.h | 6 ++++++
> kernel/irq/msi.c | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index 84859a9aa091..dc27cf3903d5 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -674,6 +674,12 @@ int platform_device_msi_init_and_alloc_irqs(struct device *dev, unsigned int nve
> void platform_device_msi_free_irqs_all(struct device *dev);
>
> bool msi_device_has_isolated_msi(struct device *dev);
> +
> +static inline int msi_domain_alloc_irqs(struct device *dev, unsigned int domid, int nirqs)
> +{
> + return msi_domain_alloc_irqs_range(dev, domid, 0, nirqs - 1);
> +}
> +
> #else /* CONFIG_GENERIC_MSI_IRQ */
> static inline bool msi_device_has_isolated_msi(struct device *dev)
> {
> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
> index f90952ebc494..2024f89baea4 100644
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -1434,6 +1434,7 @@ int msi_domain_alloc_irqs_range(struct device *dev, unsigned int domid,
> msi_unlock_descs(dev);
> return ret;
> }
> +EXPORT_SYMBOL_GPL(msi_domain_alloc_irqs_range);
>
> /**
> * msi_domain_alloc_irqs_all_locked - Allocate all interrupts from a MSI interrupt domain
> @@ -1680,6 +1681,7 @@ void msi_domain_free_irqs_range(struct device *dev, unsigned int domid,
> msi_domain_free_irqs_range_locked(dev, domid, first, last);
> msi_unlock_descs(dev);
> }
> +EXPORT_SYMBOL_GPL(msi_domain_free_irqs_all);
>
> /**
> * msi_domain_free_irqs_all_locked - Free all interrupts from a MSI interrupt domain
next prev parent reply other threads:[~2024-04-23 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 11:10 [PATCH v6 1/2] genirq/msi: add wrapper msi allocation API and export msi functions Nipun Gupta
2024-04-23 11:10 ` [PATCH v6 2/2] vfio/cdx: add interrupt support Nipun Gupta
2024-04-23 21:09 ` Alex Williamson [this message]
2024-04-24 17:21 ` [PATCH v6 1/2] genirq/msi: add wrapper msi allocation API and export msi functions Thomas Gleixner
2024-04-29 18:55 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423150920.12fe4a3e.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=abhijit.gangurde@amd.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).