From: Will Deacon <will@kernel.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: kvm@vger.kernel.org, Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH kvmtool] x86: Fix PIT2 init
Date: Fri, 19 Apr 2024 14:39:53 +0100 [thread overview]
Message-ID: <20240419133953.GD3148@willie-the-truck> (raw)
In-Reply-To: <20240415154244.2840081-1-jackmanb@google.com>
Hi Brendan,
On Mon, Apr 15, 2024 at 03:42:44PM +0000, Brendan Jackman wrote:
> KVM docs[1] for KVM_CREATE_PIT2 say:
>
> This call is only valid after enabling in-kernel irqchip support
> via KVM_CREATE_IRQCHIP.
>
> This was not enforced technically, until kernel commit 9e05d9b06757
> ("KVM: x86: Check irqchip mode before create PIT"). Now I get -ENOENT.
>
> To fix it I've just reordered the ioctls. Doing this fixes the -ENOENT
> when running a nested VM on VMX.
>
> [1] https://www.kernel.org/doc/Documentation/virtual/kvm/api.txt
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
> To: Will Deacon <will@kernel.org>
> To: Julien Thierry <julien.thierry.kdev@gmail.com>
> To: kvm@vger.kernel.org
> ---
> x86/kvm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks for the patch, but I think we already fixed this in e73a6b29f1eb
("x86: Enable in-kernel irqchip before creating PIT"). Please can you
check the latest kvmtool works for you?
Cheers,
Will
next prev parent reply other threads:[~2024-04-19 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 15:42 [PATCH kvmtool] x86: Fix PIT2 init Brendan Jackman
2024-04-19 13:39 ` Will Deacon [this message]
2024-04-19 14:23 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419133953.GD3148@willie-the-truck \
--to=will@kernel.org \
--cc=jackmanb@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).