From: Yi Liu <yi.l.liu@intel.com>
To: joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com,
baolu.lu@linux.intel.com
Cc: alex.williamson@redhat.com, robin.murphy@arm.com,
eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, yi.l.liu@intel.com,
iommu@lists.linux.dev, zhenzhong.duan@intel.com,
jacob.jun.pan@intel.com
Subject: [PATCH v2 00/12] iommufd support pasid attach/replace
Date: Fri, 12 Apr 2024 01:15:04 -0700 [thread overview]
Message-ID: <20240412081516.31168-1-yi.l.liu@intel.com> (raw)
PASID (Process Address Space ID) is a PCIe extension to tag the DMA
transactions out of a physical device, and most modern IOMMU hardwares
have supported PASID granular address translation. So a PASID-capable
device can be attached to multiple hwpts (a.k.a. domains), each attachment
is tagged with a pasid.
This series first fixes the gap of existing set_dev_pasid() callback for
supporting domain replacement, then a missing iommu API to replace domain
for a pasid. Based on the iommu pasid attach/replace/detach APIs, this
series adds iommufd APIs for device drivers to attach/replace/detach pasid
to/from hwpt per userspace's request, and adds selftest to validate the
iommufd APIs.
pasid attach/replace is mandatory on Intel VT-d given the PASID table
locates in the physical address space hence must be managed by the kernel,
both for supporting vSVA and coming SIOV. But it's optional on ARM/AMD
which allow configuring the PASID/CD table either in host physical address
space or nested on top of an GPA address space. This series only add VT-d
support as the minimal requirement.
The completed code can be found in below link [1]. Heads up! The existing
iommufd selftest was broken, there was a fix [2] to it, but not upstreamed
yet. If wants to run iommufd selftest, please apply that fix. Sorry for the
inconvenience.
[1] https://github.com/yiliu1765/iommufd/tree/iommufd_pasid
[2] https://lore.kernel.org/linux-iommu/20240111073213.180020-1-baolu.lu@linux.intel.com/
Change log:
v2:
- Domain replace for pasid should be handled in set_dev_pasid() callbacks
instead of remove_dev_pasid and call set_dev_pasid afteward in iommu
layer (Jason)
- Make xarray operations more self-contained in iommufd pasid attach/replace/detach
(Jason)
- Tweak the dev_iommu_get_max_pasids() to allow iommu driver to populate the
max_pasids. This makes the iommufd selftest simpler to meet the max_pasids
check in iommu_attach_device_pasid() (Jason)
v1: https://lore.kernel.org/kvm/20231127063428.127436-1-yi.l.liu@intel.com/#r
- Implemnet iommu_replace_device_pasid() to fall back to the original domain
if this replacement failed (Kevin)
- Add check in do_attach() to check corressponding attach_fn per the pasid value.
rfc: https://lore.kernel.org/linux-iommu/20230926092651.17041-1-yi.l.liu@intel.com/
Regards,
Yi Liu
Lu Baolu (1):
iommu/vt-d: Add set_dev_pasid callback for nested domain
Yi Liu (11):
iommu: Pass old domain to set_dev_pasid op
iommu: Introduce a replace API for device pasid
iommufd: replace attach_fn with a structure
iommufd: Support attach/replace hwpt per pasid
iommu: Allow iommu driver to populate the max_pasids
iommufd/selftest: Add set_dev_pasid and remove_dev_pasid in mock iommu
iommufd/selftest: Add a helper to get test device
iommufd/selftest: Add test ops to test pasid attach/detach
iommufd/selftest: Add coverage for iommufd pasid attach/detach
iommu/vt-d: Return if no dev_pasid is found in domain
iommu/vt-d: Make intel_iommu_set_dev_pasid() to handle domain
replacement
drivers/iommu/intel/iommu.c | 29 ++-
drivers/iommu/intel/iommu.h | 3 +
drivers/iommu/intel/nested.c | 15 ++
drivers/iommu/intel/svm.c | 3 +-
drivers/iommu/iommu-priv.h | 3 +
drivers/iommu/iommu.c | 102 ++++++++-
drivers/iommu/iommufd/Makefile | 1 +
drivers/iommu/iommufd/device.c | 43 ++--
drivers/iommu/iommufd/iommufd_private.h | 23 ++
drivers/iommu/iommufd/iommufd_test.h | 30 +++
drivers/iommu/iommufd/pasid.c | 161 ++++++++++++++
drivers/iommu/iommufd/selftest.c | 198 ++++++++++++++++-
include/linux/iommu.h | 2 +-
include/linux/iommufd.h | 6 +
tools/testing/selftests/iommu/iommufd.c | 207 ++++++++++++++++++
.../selftests/iommu/iommufd_fail_nth.c | 28 ++-
tools/testing/selftests/iommu/iommufd_utils.h | 78 +++++++
17 files changed, 888 insertions(+), 44 deletions(-)
create mode 100644 drivers/iommu/iommufd/pasid.c
--
2.34.1
next reply other threads:[~2024-04-12 8:15 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:15 Yi Liu [this message]
2024-04-12 8:15 ` [PATCH v2 01/12] iommu: Pass old domain to set_dev_pasid op Yi Liu
2024-04-15 5:32 ` Baolu Lu
2024-04-15 11:54 ` Jason Gunthorpe
2024-04-16 2:07 ` Baolu Lu
2024-04-16 17:47 ` Jason Gunthorpe
2024-04-12 8:15 ` [PATCH v2 02/12] iommu: Introduce a replace API for device pasid Yi Liu
2024-04-16 3:01 ` Duan, Zhenzhong
2024-04-16 9:18 ` Yi Liu
2024-04-17 8:44 ` Tian, Kevin
2024-04-17 12:17 ` Jason Gunthorpe
2024-04-18 0:08 ` Tian, Kevin
2024-04-29 13:55 ` Jason Gunthorpe
2024-04-30 5:00 ` Yi Liu
2024-04-30 12:26 ` Jason Gunthorpe
2024-04-12 8:15 ` [PATCH v2 03/12] iommufd: replace attach_fn with a structure Yi Liu
2024-04-12 8:15 ` [PATCH v2 04/12] iommufd: Support attach/replace hwpt per pasid Yi Liu
2024-04-29 13:56 ` Jason Gunthorpe
2024-04-12 8:15 ` [PATCH v2 05/12] iommu: Allow iommu driver to populate the max_pasids Yi Liu
2024-04-15 5:41 ` Baolu Lu
2024-04-17 8:49 ` Tian, Kevin
2024-04-20 5:45 ` Yi Liu
2024-04-22 11:52 ` Jason Gunthorpe
2024-04-12 8:15 ` [PATCH v2 06/12] iommufd/selftest: Add set_dev_pasid and remove_dev_pasid in mock iommu Yi Liu
2024-04-12 8:15 ` [PATCH v2 07/12] iommufd/selftest: Add a helper to get test device Yi Liu
2024-04-12 8:15 ` [PATCH v2 08/12] iommufd/selftest: Add test ops to test pasid attach/detach Yi Liu
2024-04-12 8:15 ` [PATCH v2 09/12] iommufd/selftest: Add coverage for iommufd " Yi Liu
2024-04-12 8:15 ` [PATCH v2 10/12] iommu/vt-d: Return if no dev_pasid is found in domain Yi Liu
2024-04-15 6:04 ` Baolu Lu
2024-04-16 9:21 ` Yi Liu
2024-04-17 2:30 ` Baolu Lu
2024-04-17 3:48 ` Yi Liu
2024-04-17 9:03 ` Tian, Kevin
2024-04-17 9:36 ` Yi Liu
2024-04-12 8:15 ` [PATCH v2 11/12] iommu/vt-d: Make intel_iommu_set_dev_pasid() to handle domain replacement Yi Liu
2024-04-17 9:19 ` Tian, Kevin
2024-04-17 9:35 ` Yi Liu
2024-04-17 12:19 ` Jason Gunthorpe
2024-04-12 8:15 ` [PATCH v2 12/12] iommu/vt-d: Add set_dev_pasid callback for nested domain Yi Liu
2024-04-17 9:25 ` Tian, Kevin
2024-04-30 9:19 ` Yi Liu
2024-05-06 7:42 ` Baolu Lu
2024-05-06 13:36 ` Jason Gunthorpe
2024-05-07 2:28 ` Yi Liu
2024-05-07 15:18 ` Jason Gunthorpe
2024-05-08 6:10 ` Yi Liu
2024-05-08 12:25 ` Jason Gunthorpe
2024-05-08 13:26 ` Yi Liu
2024-05-08 14:11 ` Jason Gunthorpe
2024-05-09 14:22 ` Liu, Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412081516.31168-1-yi.l.liu@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).